Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

Conversation

@jingxiangmo
Copy link
Contributor

@jingxiangmo jingxiangmo commented Sep 29, 2023

Description

  • I've included a concise description of what each node does

Styleguide

  • My node adheres to the styleguide for Flojoy nodes

Docs

  • I've submitted a PR for a documentation page for the new node(s) that contains usage examples (see docs.flojoy.io)

Testing

  • This PR includes a unit test (example here and/or ideally a screenshot of the node's output on an example app.

@jingxiangmo jingxiangmo requested review from 39bytes, itsjoeoui and izi-on and removed request for 39bytes September 29, 2023 12:36
@jingxiangmo jingxiangmo marked this pull request as ready for review September 29, 2023 12:37
@dstrande
Copy link
Contributor

Looks good guys. In Studio now you'll find the "connection manager", and I'm thinking it'll be better if you can integrate the connection into that. You'll have to add to the Python repo for this. Here's an example:

https://github.com/flojoy-ai/python/pull/104/files

You'll also likely need @JeffDotPng 's help setting up the frontend to search for connections. Let us know if you guys need help with this in Slack.

Copy link
Member

@itsjoeoui itsjoeoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@itsjoeoui itsjoeoui merged commit 2964551 into develop Oct 2, 2023
@itsjoeoui itsjoeoui deleted the robotics-nodes branch October 2, 2023 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants