Skip to content

NFC emulation software tunning #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skotopes merged 19 commits into from
Jul 3, 2022
Merged

NFC emulation software tunning #1341

skotopes merged 19 commits into from
Jul 3, 2022

Conversation

@gornekich
Copy link
Member

@gornekich gornekich commented Jun 24, 2022 •
edited by skotopes
Loading

What's new

  • Remove RFAL calls from mifare classic emulation
  • Rework NFC SPI handler to support transparent mode
  • Rework nfca_signal_encode and digital_signal to fixed point calculation
  • Add correct sleep request handler
  • Add unit tests for digital signal

Verification

  • Mifare Classic emulation fits timings
  • NFC unit tests passed

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gornekich gornekich marked this pull request as draft June 24, 2022 16:10
@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited
Loading

Install with web updater.

@gornekich gornekich marked this pull request as ready for review June 28, 2022 14:42
@skotopes skotopes merged commit 5769595 into dev Jul 3, 2022
@skotopes skotopes deleted the gornek/2606_classic_emulation_tunning branch July 3, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gornekich @skotopes