fix: preserve report url through cache serialization#2363
fix: preserve report url through cache serialization#2363kovsu merged 1 commit intoflint-fyi:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 1ab5e91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
||
| if (report.about.url) { | ||
| yield `${indenter} `; | ||
| yield `\n${indenter}\n${indenter} `; |
There was a problem hiding this comment.
nit: do we need an indention on an empty line?
There was a problem hiding this comment.
Not, it's not the empty line. It's the line for report url.
There was a problem hiding this comment.
I think he means this:
| yield `\n${indenter}\n${indenter} `; | |
| yield `\n\n${indenter} `; |
There was a problem hiding this comment.
I think he means this:
if not indenter here
There was a problem hiding this comment.
Oh, so indenter includes what Clack terms the "guide". Hmmm... would be nice if there was a better name to communicate that but not sure of one.
(And cc @michaelfaith to make sure we're on the same page)
There was a problem hiding this comment.
Yes, that's what I was referring to. 👍
Hmmm... would be nice if there was a better name to communicate that but not sure of one
Also agree with this. Maybe frameWithIndent? But I also think that could be a separate change.
michaelfaith
added
the
1 approval
There was a problem hiding this comment.
Makes me wonder if we should use z.infer instead of defining these separately, but that's certainly a followup.
3 participants
PR Checklist
status: accepting prsOverview