feat(ts): implement unnecessaryLogicalComparisons rule#2259
Draft
feat(ts): implement unnecessaryLogicalComparisons rule#2259
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Co-authored-by: JoshuaKGoldberg <[email protected]>
Co-authored-by: JoshuaKGoldberg <[email protected]>
Copilot
AI
changed the title
[WIP] Add unnecessaryLogicalComparisons rule to TypeScript plugin
feat(ts): implement unnecessaryLogicalComparisons rule
Feb 1, 2026
Collaborator
|
The backing typescript-eslint rule is a good bit more complex. Marking as blocked until we have more built-up practices around Flint rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements lint rule to detect and simplify unnecessary boolean literal comparisons in TypeScript code.
Changes
Rule implementation (
packages/ts/src/rules/unnecessaryLogicalComparisons.ts)===,!==) and loose (==,!=) operatorsTest coverage (
packages/ts/src/rules/unnecessaryLogicalComparisons.test.ts)Registration
Examples
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
typescript-eslint.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.