Conversation
It's easier to deal with header files when it's unconditionally safe to include the same header more than once. In particular the absence of `#pragma once` in `glib-backports.h` caused a build failure in #191, but only for older GLib releases. Signed-off-by: Simon McVittie <smcv@debian.org>
This is slightly more efficient, and removes any concerns about whether we have reused the same macro name for two different headers. Signed-off-by: Simon McVittie <smcv@debian.org>
TingPing
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
#pragma oncein all headers that do not already have guardsIt's easier to deal with header files when it's unconditionally safe to
include the same header more than once.
In particular the absence of
#pragma onceinglib-backports.hcauseda build failure in inputcapture: Reference-count Call objects #191, but only for older GLib releases.
Qt: Use
#pragma onceinstead of traditional single-inclusion guardsThis is slightly more efficient, and removes any concerns about whether
we have reused the same macro name for two different headers.