Remove (closure) annotations

[A6GibKm]

The (closure) annotation should go in the callback parameter, e.g.

* @callback: (scope async) (closure data): a callback ...

however gobject-introspection will automatically pick up a parameter called data as the parameter of the callback.

Fixes the warnings:

[36/45] Generating libportal/Xdp-1.0.gir with a custom command (wrapped by meson to set env)
../libportal/account.c:209: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/background.c:329: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/background.c:399: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/camera.c:218: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/dynamic-launcher.c:236: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/email.c:308: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/filechooser.c:245: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/filechooser.c:353: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/filechooser.c:446: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/inhibit.c:218: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/inhibit.c:569: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/inputcapture.c:727: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/location.c:330: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/notification.c:723: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/openuri.c:277: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/openuri.c:344: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/print.c:280: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/print.c:358: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/remote.c:460: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/remote.c:530: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/remote.c:570: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/remote.c:808: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/screenshot.c:224: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/screenshot.c:288: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/spawn.c:203: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/trash.c:128: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/updates.c:208: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/updates.c:391: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters
../libportal/wallpaper.c:286: Warning: Xdp: invalid "closure" annotation: only valid on callback parameters

[A6GibKm]

cc: @ebassi, the warning is a bit confusing, it makes me thing that the closure annotation should indeed go in the callback's parameter (data) instead of the callback parameter (callback) .

[ebassi]

It doesn't say "the callback's parameter", though. The warning says: "the callback parameter", i.e. the parameter that is a callback.

We cannot put a whole treatise into a warning: people already don't read them as is.

[ebassi]

however gobject-introspection will automatically pick up a parameter called data as the parameter of the callback.

It actually picks up anything that ends with data, and is a gpointer, though the documented rule is to use user_data as the name of a closure argument.

[A6GibKm]

however gobject-introspection will automatically pick up a parameter called data as the parameter of the callback.

It actually picks up anything that ends with data, and is a gpointer, though the documented rule is to use user_data as the name of a closure argument.

I updated the commit description, would it be better if I renamed them to user_data instead?

[ebassi]

I updated the commit description, would it be better if I renamed them to user_data instead?

It's fine either way; user_data is generally more idiomatic of GLib-based libraries, but it's not fundamental.

[smcv]

This seems good to me. @ebassi?

[ebassi]

Yes, looks good to me.