Fix some Meson warnings by officially requiring 0.55.0#181
Merged
smcv merged 3 commits intoflatpak:mainfrom Jan 2, 2025
Merged
Fix some Meson warnings by officially requiring 0.55.0#181smcv merged 3 commits intoflatpak:mainfrom
smcv merged 3 commits intoflatpak:mainfrom
Conversation
In practice the GTK3 backend accidentally required 0.55.0 since 0.8.0, and nobody seems to have complained or even noticed. Fixes: f7f3acf "portal-test/gtk3: Don't provide a run target if we cannot run it" Signed-off-by: Simon McVittie <smcv@debian.org>
This raises a deprecation warning with newer Meson, and now that we officially require Meson 0.55.0, we can use it unconditionally. Signed-off-by: Simon McVittie <smcv@debian.org>
Newer Meson issues a warning if we don't specify whether we plan to compile code for the build architecture or not when adding a language. Like most projects, this one doesn't seem to ever compile for the build architecture, only for the host architecture, so when cross-compiling it will only need a host-architecture C++ compiler. For example, if we're cross-compiling for riscv64 on x86_64, we will need a riscv64 cross-compiler, but we don't need an x86_64 native compiler. Instruct Meson not to look for one. Signed-off-by: Simon McVittie <smcv@debian.org>
GeorgesStavracas
approved these changes
Jan 2, 2025
Member
GeorgesStavracas
left a comment
There was a problem hiding this comment.
LGTM. I think I prefer bumping the Meson requirement to 0.55 instead of supporting older Meson versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build: Officially require Meson 0.55.0
In practice the GTK3 backend accidentally required 0.55.0 since 0.8.0,
and nobody seems to have complained or even noticed.
Fixes: f7f3acf "portal-test/gtk3: Don't provide a run target if we cannot run it"
gtk4: Replace deprecated path() method with full_path()
This raises a deprecation warning with newer Meson, and now that we
officially require Meson 0.55.0, we can use it unconditionally.
build: Never require a C++ compiler for the build architecture
Newer Meson issues a warning if we don't specify whether we plan to
compile code for the build architecture or not when adding a language.
Like most projects, this one doesn't seem to ever compile for the build
architecture, only for the host architecture, so when cross-compiling it
will only need a host-architecture C++ compiler.
For example, if we're cross-compiling for riscv64 on x86_64, we
will need a riscv64 cross-compiler, but we don't need an x86_64 native
compiler. Instruct Meson not to look for one.
Alternatively we could continue to only require 0.49.0 with some simple changes to the gtk3 and gtk4 backends, but Meson ≥ 0.55.0 is available since Debian 10 (which is superseded and EOL) and CentOS/RHEL 8 (which is superseded but I think still supported), so maybe we don't need to go that far into retrocomputing? The main things we'd lose the ability to compile on by bumping the requirement to 0.55.0 are CentOS/RHEL 7 and Ubuntu 20.04, which have been superseded but I believe are still supported to some extent.