notification: Ensure that g_autoptr variable is initialized#180
Merged
TingPing merged 1 commit intoflatpak:mainfrom Jan 1, 2025
Merged
notification: Ensure that g_autoptr variable is initialized#180TingPing merged 1 commit intoflatpak:mainfrom
TingPing merged 1 commit intoflatpak:mainfrom
Conversation
If the function early-returns (which it currently does not, but that would be a reasonable change to make) then we'd call g_object_unref() on uninitialized stack memory. gcc 14.2.0 in the freedesktop SDK 24.08 warns about this. It's better to make sure that every autofreed variable is initialized, possibly to NULL. Signed-off-by: Simon McVittie <smcv@debian.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the function early-returns (which it currently does not, but that would be a reasonable change to make) then we'd call g_object_unref() on uninitialized stack memory. gcc 14.2.0 in the freedesktop SDK 24.08 warns about this.
It's better to make sure that every autofreed variable is initialized, possibly to NULL.