Skip to content

Add zoomus.conf support#212

Merged
barthalion merged 3 commits intoflathub:masterfrom
TheEvilSkeleton:zoomus
Sep 28, 2020
Merged

Add zoomus.conf support#212
barthalion merged 3 commits intoflathub:masterfrom
TheEvilSkeleton:zoomus

Conversation

@TheEvilSkeleton
Copy link
Contributor

@TheEvilSkeleton TheEvilSkeleton commented Sep 26, 2020

Fix #204

@flathubbot
Copy link
Contributor

Started test build 28452

@flathubbot
Copy link
Contributor

Build 28452 failed

@TheEvilSkeleton
Copy link
Contributor Author

F

@TheEvilSkeleton
Copy link
Contributor Author

ln: failed to create symbolic link '/srv/buildbot/.var/app/us.zoom.Zoom/.config/zoomus.conf': No such file or directory

Maybe creating a file might work

@flathubbot
Copy link
Contributor

Started test build 28453

@TheEvilSkeleton
Copy link
Contributor Author

Hope it works

@flathubbot
Copy link
Contributor

Build 28453 failed

@flathubbot
Copy link
Contributor

Started test build 28454

@flathubbot
Copy link
Contributor

Build 28454 failed

@flathubbot
Copy link
Contributor

Started test build 28455

@flathubbot
Copy link
Contributor

Build 28455 failed

@TheEvilSkeleton
Copy link
Contributor Author

Running: mkdir -p ~/.var/app/us.zoom.Zoom/.config
Running: ls -a ~/.var/app/us.zoom.Zoom/
ls: cannot access '/srv/buildbot/.var/app/us.zoom.Zoom/': No such file or directory

Weird...

@flathubbot
Copy link
Contributor

Started test build 28456

@flathubbot
Copy link
Contributor

Build 28456 failed

@TheEvilSkeleton
Copy link
Contributor Author

Running: mkdir -pv ~/.var/app/us.zoom.Zoom/.config
mkdir: created directory '/srv/buildbot/.var'
mkdir: created directory '/srv/buildbot/.var/app'
mkdir: created directory '/srv/buildbot/.var/app/us.zoom.Zoom'
mkdir: created directory '/srv/buildbot/.var/app/us.zoom.Zoom/.config'
ls: cannot access '/srv/buildbot/.var/app/us.zoom.Zoom/': No such file or directory

Maybe I'm just doing everything wrongly

@flathubbot
Copy link
Contributor

Started test build 28457

@flathubbot
Copy link
Contributor

Build 28457 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27397/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 28458

@flathubbot
Copy link
Contributor

Build 28458 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27398/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 28459

@flathubbot
Copy link
Contributor

Build 28459 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27399/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 28461

@flathubbot
Copy link
Contributor

Build 28461 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27401/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 28462

@flathubbot
Copy link
Contributor

Build 28462 failed

@flathubbot
Copy link
Contributor

Started test build 28463

@flathubbot
Copy link
Contributor

Build 28463 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27402/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 28464

@flathubbot
Copy link
Contributor

Build 28464 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27403/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 28465

@flathubbot
Copy link
Contributor

Started test build 28467

@flathubbot
Copy link
Contributor

Build 28467 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27405/us.zoom.Zoom.flatpakref

@heftig
Copy link

heftig commented Sep 26, 2020

I tried flatpak install --user https://dl.flathub.org/build-repo/27405/us.zoom.Zoom.flatpakref and it seems to work.

@TheEvilSkeleton
Copy link
Contributor Author

Same for me. It worked like a charm. Thank you so much

@flathubbot
Copy link
Contributor

Started test build 28468

@flathubbot
Copy link
Contributor

Build 28468 failed

@TheEvilSkeleton
Copy link
Contributor Author

Crap, I wrongly git push

@flathubbot
Copy link
Contributor

Started test build 28470

@flathubbot
Copy link
Contributor

Build 28470 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27408/us.zoom.Zoom.flatpakref

@TheEvilSkeleton TheEvilSkeleton changed the title WIP: Add Zoomus support Add zoomus.conf support Sep 26, 2020
@TheEvilSkeleton
Copy link
Contributor Author

@heftig so I just chatted with a Flatpak contributor, and they advised me to not do that

Screenshot from 2020-09-26 16-18-38

@TheEvilSkeleton
Copy link
Contributor Author

I'll keep it as is because it's a very important PR. Having minor annoyances isn't that important compared to not being able to change a configuration file.

@TheEvilSkeleton
Copy link
Contributor Author

Not entirely sure, but #143 might be a better fix. I just have to check if theirs work or not.

@heftig
Copy link

heftig commented Sep 26, 2020

#143 is not a fix for this.

@TheEvilSkeleton
Copy link
Contributor Author

Yeah, I tried it but the issue still persists, unfortunately

@TheEvilSkeleton
Copy link
Contributor Author

@barthalion feel free to merge it

@barthalion
Copy link
Member

What was wrong with --persist=.config? It sounds like proper solution here.

@TheEvilSkeleton
Copy link
Contributor Author

The problem is that it would duplicate config, so it Zoom's Flatpak's directory, there would be both config and .config folders, which is a bit annoying to deal with.

But replacing the current PR with --persist=.config would prevent the issue #212 (comment), which in my opinion is a better idea. I'll update the PR so for those that want to allow filesystem=home won't have the infiniloop of .configs.

@flathubbot
Copy link
Contributor

Started test build 28668

@flathubbot
Copy link
Contributor

Build 28668 failed

@flathubbot
Copy link
Contributor

Started test build 28669

@flathubbot
Copy link
Contributor

Build 28669 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27601/us.zoom.Zoom.flatpakref

@barthalion barthalion merged commit 9dbdebc into flathub:master Sep 28, 2020
@TheEvilSkeleton TheEvilSkeleton deleted the zoomus branch September 28, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scaling Issues in this week's update

4 participants