Skip to content

Conversation

@dongsupark
Copy link
Member

@dongsupark dongsupark commented Jul 10, 2025

Starting from Rust 1.88, clippy prints out warnings in case of uninlined format arguments in format strings.
Fix them to unblock CI.

error: variables can be used directly in the `format!` string
Error:   --> omaha/src/response.rs:70:29
   |
70 |             _ => return Err(format!("unknown success action \"{}\"", s)),
   |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
   = note: `-D clippy::uninlined-format-args` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
   |
70 -             _ => return Err(format!("unknown success action \"{}\"", s)),
70 +             _ => return Err(format!("unknown success action \"{s}\"")),

Fixes #70

Starting from Rust 1.88, clippy prints out warnings in case of uninlined
format arguments in format strings. Fix them to unblock CI.

```
error: variables can be used directly in the `format!` string
Error:   --> omaha/src/response.rs:70:29
   |
70 |             _ => return Err(format!("unknown success action \"{}\"", s)),
   |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
   = note: `-D clippy::uninlined-format-args` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
   |
70 -             _ => return Err(format!("unknown success action \"{}\"", s)),
70 +             _ => return Err(format!("unknown success action \"{s}\"")),
```
@dongsupark dongsupark requested a review from a team July 10, 2025 14:38
Copy link
Member

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe somehow disabling this lint could be the way forward, but you already did the work addressing it, so I guess it's fine to go in.

@dongsupark dongsupark merged commit c6b365b into main Jul 15, 2025
3 checks passed
@dongsupark dongsupark deleted the dongsu/fix-clippy-1.88 branch July 15, 2025 10:02
dongsupark added a commit to flatcar/scripts that referenced this pull request Sep 26, 2025
dongsupark added a commit to flatcar/scripts that referenced this pull request Sep 26, 2025
dongsupark added a commit to flatcar/scripts that referenced this pull request Sep 26, 2025
dongsupark added a commit to flatcar/scripts that referenced this pull request Sep 26, 2025
dongsupark added a commit to flatcar/scripts that referenced this pull request Sep 27, 2025
dongsupark added a commit to flatcar/scripts that referenced this pull request Sep 27, 2025
dongsupark added a commit to flatcar/scripts that referenced this pull request Sep 30, 2025
sambonbonne pushed a commit to sambonbonne/flatcar-scripts that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo clippy errors with Rust 1.88+

3 participants