-
Notifications
You must be signed in to change notification settings - Fork 6
*: fix clippy issues with Rust 1.88+. #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from Rust 1.88, clippy prints out warnings in case of uninlined
format arguments in format strings. Fix them to unblock CI.
```
error: variables can be used directly in the `format!` string
Error: --> omaha/src/response.rs:70:29
|
70 | _ => return Err(format!("unknown success action \"{}\"", s)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-D clippy::uninlined-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
70 - _ => return Err(format!("unknown success action \"{}\"", s)),
70 + _ => return Err(format!("unknown success action \"{s}\"")),
```
krnowak
approved these changes
Jul 11, 2025
Member
krnowak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe somehow disabling this lint could be the way forward, but you already did the work addressing it, so I guess it's fine to go in.
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 26, 2025
Pulls in flatcar/ue-rs#72, flatcar/ue-rs#74, flatcar/ue-rs#84, flatcar/ue-rs#85, flatcar/ue-rs#87, flatcar/ue-rs#88. Signed-off-by: Dongsu Park <[email protected]>
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 26, 2025
Pulls in flatcar/ue-rs#72, flatcar/ue-rs#74, flatcar/ue-rs#84, flatcar/ue-rs#85, flatcar/ue-rs#87, flatcar/ue-rs#88. Signed-off-by: Dongsu Park <[email protected]>
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 26, 2025
Pulls in flatcar/ue-rs#72, flatcar/ue-rs#84, flatcar/ue-rs#85, flatcar/ue-rs#87, flatcar/ue-rs#88. Signed-off-by: Dongsu Park <[email protected]>
1 task
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 26, 2025
Pulls in flatcar/ue-rs#72, flatcar/ue-rs#84, flatcar/ue-rs#85, flatcar/ue-rs#87, flatcar/ue-rs#88, flatcar/ue-rs#90. Signed-off-by: Dongsu Park <[email protected]>
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 27, 2025
Pulls in flatcar/ue-rs#72, flatcar/ue-rs#84, flatcar/ue-rs#85, flatcar/ue-rs#87, flatcar/ue-rs#88, flatcar/ue-rs#90. Signed-off-by: Dongsu Park <[email protected]>
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 27, 2025
Pulls in flatcar/ue-rs#72, flatcar/ue-rs#84, flatcar/ue-rs#85, flatcar/ue-rs#87, flatcar/ue-rs#88, flatcar/ue-rs#90. Signed-off-by: Dongsu Park <[email protected]>
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 30, 2025
Pulls in flatcar/ue-rs#72, flatcar/ue-rs#84, flatcar/ue-rs#85, flatcar/ue-rs#87, flatcar/ue-rs#88, flatcar/ue-rs#90. Signed-off-by: Dongsu Park <[email protected]>
sambonbonne
pushed a commit
to sambonbonne/flatcar-scripts
that referenced
this pull request
Oct 3, 2025
Pulls in flatcar/ue-rs#72, flatcar/ue-rs#84, flatcar/ue-rs#85, flatcar/ue-rs#87, flatcar/ue-rs#88, flatcar/ue-rs#90. Signed-off-by: Dongsu Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from Rust 1.88, clippy prints out warnings in case of uninlined format arguments in format strings.
Fix them to unblock CI.
Fixes #70