-
Notifications
You must be signed in to change notification settings - Fork 81
sys-kernel/coreos-modules: enable CONFIG_MEMCG_V1 #3289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@thechristschn you're running nodes with cgroups v2 but the jre version you're using checks that the host kernel still supports v1 controllers? Even if these v1 controllers are not active and managed by cgroupsv2? |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/19166952267 |
|
@jepio Unfortunately that's a deficiency of OpenJDK, see https://bugs.openjdk.org/browse/JDK-8346874 and https://bugs.openjdk.org/browse/JDK-8347129 |
ead64cc to
dafa00c
Compare
0e55c10 to
6f04e90
Compare
|
Someone please rebase this. |
6f04e90 to
fe546e8
Compare
@chewi Done |
fe546e8 to
c313036
Compare
c313036 to
0b7068d
Compare
|
Sorry, I forgot that the CI still didn't work properly for forks. I'll handle it. |
Signed-off-by: Christian Baumann <[email protected]> Signed-off-by: James Le Cuirot <[email protected]>
Signed-off-by: Christian Baumann <[email protected]> Signed-off-by: James Le Cuirot <[email protected]>
0b7068d to
db77f16
Compare
chewi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I ran CI in a local branch here and it basically passed. Merging now. Sorry for the wait!
|
@chewi can you verify if this has been backported to Beta at one point? I don't see it in the release notes (only on current Alpha) |
|
It wasn't. I've applied it to 4459 now. |
With Kernel 6.12 the cgroup behavior changed which causes cgroup detection in JVM to break.
The previous fix in #3263 wasn't sufficient, we also need to enable
CONFIG_MEMCG_V1.Fixes flatcar/Flatcar#1884
How to use
Build and deploy flatcar with the kernel parameter and execute tests below.
Testing done
To validate that the first attempt to fix the problem in #3263 is necessary as well:
Java complains, that cpuset and memory controller are missing and falls back to available system memory, which was fixed in #3263.
Behavior with current alpha/beta release on system with 2GB memory:
50% of the host memory is used for heap instead of 50% of the container memory limit. The debug logs complain about missing memory controller.
Behavior with this change:
This time 50% of the container memory limit is used for heap, which is what we want. Also the debug logs show, that cgroupv2 is detected.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.