[Bug] Fix spark unit test failures for test_add_rmsnorm_fp4_quant_cute_dsl#2573
Conversation
kahyunnam
requested review from
aleozlx,
bkryu,
jimmyzho,
kaixih and
yzh119
as code owners
Summary of ChangesHello @kahyunnam, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical failures in Spark unit tests related to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
kahyunnam
changed the title
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughRemoves Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/bot run |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively resolves two issues: a ModuleNotFoundError by removing an obsolete import in flashinfer/cute_dsl/__init__.py, and a race condition in flashinfer/cute_dsl/add_rmsnorm_fp4quant.py. The fix for the race condition, which involves adding memory fencing and cluster synchronization, is a crucial correction. The changes are well-commented and directly address the test failures described in the pull request. I've added one suggestion for a potential performance optimization regarding the memory fence scope. Overall, this is a good fix.
|
/bot run |
|
Benchmarking results: Before fix: After fix: |
bkryu
left a comment
bkryu
left a comment
There was a problem hiding this comment.
LGTM. Let's wait merging until the internal results come back, although I don't expect any failures.
|
[FAILED] Pipeline #44234479: 16/20 passed |
B300 only failed due to exceeded time, considering this passing |
3 participants
📌 Description
Fixes failing
test_add_rmsnorm_fp4_quant_cute_dslunit tests on Spark:Module import fix for:
Race condition fix for:
New test results after this PR applied:
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes
Summary by CodeRabbit
Bug Fixes
Chores