Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ci/docker-tags.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
flashinfer/flashinfer-ci-cu126: 20251217-f059241
flashinfer/flashinfer-ci-cu128: 20251217-f059241
flashinfer/flashinfer-ci-cu129: 20251217-f059241
flashinfer/flashinfer-ci-cu130: 20251217-f059241
flashinfer/flashinfer-ci-cu126: 20260105-a97b5d7
flashinfer/flashinfer-ci-cu128: 20260105-a97b5d7
flashinfer/flashinfer-ci-cu129: 20260105-a97b5d7
flashinfer/flashinfer-ci-cu130: 20260105-a97b5d7
Comment on lines +1 to +4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, you can use a YAML anchor for the Docker tag. This way, the tag is defined in one place, making it easier to update in the future. This also simplifies the automation that generates these updates, as it would only need to change a single value.

Note: This suggestion uses a key .tag which is a convention for "hidden" keys in YAML that are often ignored by parsers but can be used for anchors. You may need to ensure your CI script that consumes this file can handle this format (e.g., by using a standard YAML parser).

.tag: &tag 20260105-a97b5d7
flashinfer/flashinfer-ci-cu126: *tag
flashinfer/flashinfer-ci-cu128: *tag
flashinfer/flashinfer-ci-cu129: *tag
flashinfer/flashinfer-ci-cu130: *tag
References
  1. To improve maintainability and reduce redundancy, repeated values should be defined once and reused. This is commonly known as the Don't Repeat Yourself (DRY) principle.