Skip to content

log JSON-RPC error data if present#723

Merged
ilyaluk merged 1 commit into
mainfrom
feature/log-err-detail
May 7, 2025
Merged

log JSON-RPC error data if present#723
ilyaluk merged 1 commit into
mainfrom
feature/log-err-detail

Conversation

@ilyaluk
Copy link
Copy Markdown
Collaborator

@ilyaluk ilyaluk commented May 7, 2025

📝 Summary

Add more verbose error logging, if err extra data is present

⛱ Motivation and Context

📚 References


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@ilyaluk ilyaluk requested review from Copilot and metachris May 7, 2025 17:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances error logging in the JSON-RPC request handling logic by including extra error data when present. This allows for more detailed error messages in cases where the error object has additional context.

  • Introduces a conditional check for extra error data within the error block.
  • Updates the error formatting to include the extra data when available.

@ilyaluk ilyaluk merged commit 0eeb02d into main May 7, 2025
5 checks passed
@ilyaluk ilyaluk deleted the feature/log-err-detail branch May 7, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants