Decouple logic and periodic scheduling from internal tasks#633
Merged
Conversation
Collaborator
|
I think the direction makes sense. I feel it's a bit confusing to split these up into a function with the same name but I would prefer to be more explicit and use |
metachris
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR decouples some internal logic in Housekeeper and API in two functions, one with the core logic and another one that decides whether the core logic is executed or not given the slot.
📚 References
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md