Skip to content

Clean up logging when payload attributes are unknown#579

Merged
avalonche merged 1 commit into
flashbots:mainfrom
austonst:attribute-unknown-logging
Mar 21, 2024
Merged

Clean up logging when payload attributes are unknown#579
avalonche merged 1 commit into
flashbots:mainfrom
austonst:attribute-unknown-logging

Conversation

@austonst
Copy link
Copy Markdown
Contributor

@austonst austonst commented Feb 7, 2024

📝 Summary

checkSubmissionPayloadAttrs() has some recent logging additions which print additional variables, but do not use the standard format of log.WithFields(...).Warn("msg"). This means that every time we would get a "payload attributes not (yet) known" warning, a few extra lines are printed with confusing messages (e.g. msg="true", msg="payload951687attrs951685") and a lot of duplicated info. This just cleans up logging a little.

I figure these were added for some quick debugging; the other option is to remove the log.Info() lines entirely. I noticed this a while back but need to figure out how to properly use GitHub's reviewing functionality.

⛱ Motivation and Context

📚 References


✅ I have run these commands

  • [✅] make lint
  • [✅] make test-race
  • [✅] go mod tidy
  • [✅] I have seen and agree to CONTRIBUTING.md

@austonst austonst force-pushed the attribute-unknown-logging branch from fd11a87 to 3207936 Compare February 7, 2024 17:49
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8a0d7b) 36.22% compared to head (3207936) 36.24%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
+ Coverage   36.22%   36.24%   +0.02%     
==========================================
  Files          24       24              
  Lines        5267     5269       +2     
==========================================
+ Hits         1908     1910       +2     
  Misses       3112     3112              
  Partials      247      247              
Flag Coverage Δ
unittests 36.24% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avalonche avalonche merged commit d61f228 into flashbots:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants