Clean up logging when payload attributes are unknown#579
Merged
Conversation
fd11a87 to
3207936
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
+ Coverage 36.22% 36.24% +0.02%
==========================================
Files 24 24
Lines 5267 5269 +2
==========================================
+ Hits 1908 1910 +2
Misses 3112 3112
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
avalonche
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
checkSubmissionPayloadAttrs()has some recent logging additions which print additional variables, but do not use the standard format oflog.WithFields(...).Warn("msg"). This means that every time we would get a "payload attributes not (yet) known" warning, a few extra lines are printed with confusing messages (e.g. msg="true", msg="payload951687attrs951685") and a lot of duplicated info. This just cleans up logging a little.I figure these were added for some quick debugging; the other option is to remove the
log.Info()lines entirely. I noticed this a while back but need to figure out how to properly use GitHub's reviewing functionality.⛱ Motivation and Context
📚 References
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md