This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Build on a single head #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
reviewed
Apr 7, 2023
| b.slotAttrs = nil | ||
| b.slotCtx = slotCtx | ||
| b.slotCtxCancel = slotCtxCancel | ||
| if b.slotCtxCancel != nil { |
Contributor
There was a problem hiding this comment.
shouldn't it check the payload is not already known before cancel?
Collaborator
Author
There was a problem hiding this comment.
It could, but it might just as well cancel anyway
avalonche
reviewed
Apr 7, 2023
| b.slotCtx = slotCtx | ||
| b.slotCtxCancel = slotCtxCancel | ||
|
|
||
| for _, currentAttrs := range b.slotAttrs { |
Contributor
There was a problem hiding this comment.
note for future clean up: this loop has no effect as slotAttrs = nil
Ruteri
added a commit
that referenced
this pull request
Apr 10, 2023
* Add handling multiple beacon clients * Initialize stop channel in builder.Builder * fix withdrawals array pointer * Build on a single head (#59) * Build on a single head * Forcibly stop building process for old sse events --------- Co-authored-by: avalonche <[email protected]>
avalonche
added a commit
that referenced
this pull request
Apr 10, 2023
* Add SSE subscription to builder * withdrawals marshalling * add stop channel * pr comments * Add handling multiple beacon clients (#57) * Add handling multiple beacon clients * Initialize stop channel in builder.Builder * fix withdrawals array pointer * Build on a single head (#59) * Build on a single head * Forcibly stop building process for old sse events --------- Co-authored-by: avalonche <[email protected]> * linting --------- Co-authored-by: Mateusz Morusiewicz <[email protected]>
avalonche
added a commit
that referenced
this pull request
Jul 6, 2023
* Add SSE subscription to builder * withdrawals marshalling * add stop channel * pr comments * Add handling multiple beacon clients (#57) * Add handling multiple beacon clients * Initialize stop channel in builder.Builder * fix withdrawals array pointer * Build on a single head (#59) * Build on a single head * Forcibly stop building process for old sse events --------- Co-authored-by: avalonche <[email protected]> * linting --------- Co-authored-by: Mateusz Morusiewicz <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Forces building on a single head. With how sse events are set up, as well as how proposers usually act, it's best to ignore blocks coming in after 4 seconds into the slot.
This might change in the future!
📚 References
CONTRIBUTING.md