This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Bundle cancellations #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flashbotsextra/database.go
Outdated
| insertBuiltBlockStmt *sqlx.NamedStmt | ||
| insertMissingBundleStmt *sqlx.NamedStmt | ||
| fetchPrioBundlesStmt *sqlx.NamedStmt | ||
| fetchGetLatestUuidBundles *sqlx.NamedStmt |
Contributor
There was a problem hiding this comment.
Nitpicking : to make it consistent
Suggested change
| fetchGetLatestUuidBundles *sqlx.NamedStmt | |
| fetchGetLatestUuidBundlesStmt *sqlx.NamedStmt |
hsouf
reviewed
Jan 2, 2023
| } | ||
|
|
||
| return simBundles, nil | ||
| ccBundles := <-ccBundlesCh |
There was a problem hiding this comment.
Nitpick: I wouldn't separate the simulation of bundles here, as long as I don't return simBundles & simCcBundles separately. But I would add a log to give an insight on the size of simCcBundles.
Collaborator
Author
There was a problem hiding this comment.
The bundles coming from the channel are not ready when we start the simulation of the other bundles, it can take up to few ms for the channel to be ready.
|
What is actually the reason to submit the block every 500ms. From experience the best block is usually built in the last second of the slot time. Wouldn't it be more efficient to start the building job in the last third or quarter to reduce load on the relays? |
Collaborator
Author
The builder doesn't know when is the proposer going to request the block. The proposer is free to chose any time they want. |
dvush
approved these changes
Jan 16, 2023
bhakiyakalimuthu
approved these changes
Jan 16, 2023
avalonche
pushed a commit
that referenced
this pull request
Feb 7, 2023
Introduces bundle replacement and cancellation via replacementUuid. Since the replacement is tied to a specific sender, eth_sendBundle gets two additional optional fields: the replacement uuid and the signingAddress of the bundle submission. The DB requests are done in the background, and cancellations are resolved while non-cancelable bundles are already being simulated to avoid waiting for DB to reply. If anything goes wrong with the cancellations, the cancelable bundles are not considered. Note: every block is now sent to the relay, as we can no longer rely on the highest-profit rule!
avalonche
pushed a commit
that referenced
this pull request
Mar 9, 2023
Introduces bundle replacement and cancellation via replacementUuid. Since the replacement is tied to a specific sender, eth_sendBundle gets two additional optional fields: the replacement uuid and the signingAddress of the bundle submission. The DB requests are done in the background, and cancellations are resolved while non-cancelable bundles are already being simulated to avoid waiting for DB to reply. If anything goes wrong with the cancellations, the cancelable bundles are not considered. Note: every block is now sent to the relay, as we can no longer rely on the highest-profit rule!
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
* miner logs * builder logs
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
Introduces bundle replacement and cancellation via replacementUuid. Since the replacement is tied to a specific sender, eth_sendBundle gets two additional optional fields: the replacement uuid and the signingAddress of the bundle submission. The DB requests are done in the background, and cancellations are resolved while non-cancelable bundles are already being simulated to avoid waiting for DB to reply. If anything goes wrong with the cancellations, the cancelable bundles are not considered. Note: every block is now sent to the relay, as we can no longer rely on the highest-profit rule!
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
* miner logs * builder logs
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
Introduces bundle replacement and cancellation via replacementUuid. Since the replacement is tied to a specific sender, eth_sendBundle gets two additional optional fields: the replacement uuid and the signingAddress of the bundle submission. The DB requests are done in the background, and cancellations are resolved while non-cancelable bundles are already being simulated to avoid waiting for DB to reply. If anything goes wrong with the cancellations, the cancelable bundles are not considered. Note: every block is now sent to the relay, as we can no longer rely on the highest-profit rule!
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
* miner logs * builder logs
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
Introduces bundle replacement and cancellation via replacementUuid. Since the replacement is tied to a specific sender, eth_sendBundle gets two additional optional fields: the replacement uuid and the signingAddress of the bundle submission. The DB requests are done in the background, and cancellations are resolved while non-cancelable bundles are already being simulated to avoid waiting for DB to reply. If anything goes wrong with the cancellations, the cancelable bundles are not considered. Note: every block is now sent to the relay, as we can no longer rely on the highest-profit rule!
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
Introduces bundle replacement and cancellation via replacementUuid. Since the replacement is tied to a specific sender, eth_sendBundle gets two additional optional fields: the replacement uuid and the signingAddress of the bundle submission. The DB requests are done in the background, and cancellations are resolved while non-cancelable bundles are already being simulated to avoid waiting for DB to reply. If anything goes wrong with the cancellations, the cancelable bundles are not considered. Note: every block is now sent to the relay, as we can no longer rely on the highest-profit rule!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Introduces bundle replacement and cancellation via
replacementUuid.Since the replacement is tied to a specific sender,
eth_sendBundlegets two additional optional fields: the replacement uuid and the signingAddress of the bundle submission.func (b *EthAPIBackend) SendBundle(ctx context.Context, txs types.Transactions, blockNumber rpc.BlockNumber, uuid uuid.UUID, signingAddress common.Address, minTimestamp uint64, maxTimestamp uint64, revertingTxHashes []common.Hash) error.The DB requests are done in the background, and cancellations are resolved while non-cancelable bundles are already being simulated to avoid waiting for DB to reply.
If anything goes wrong with the cancellations, the cancelable bundles are not considered.
Note: every block is now sent to the relay, as we can no longer rely on the highest-profit rule!
📚 References
Cancellations docs: https://github.com/flashbots/flashbots-docs/pull/317/files
CONTRIBUTING.md