This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Work on local devnet #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good, let's rebase and merge once #20 is merged (has some other necessary fixes) |
ghost
approved these changes
Dec 19, 2022
ghost
approved these changes
Dec 19, 2022
dvush
force-pushed
the
work-on-local-devnet
branch
from
5a15daa to
646d6ba
Compare
Ruteri
reviewed
Dec 21, 2022
| timer.Reset(recommit) | ||
| continue | ||
| } | ||
| //if atomic.LoadInt32(&w.newTxs) == 0 { |
Collaborator
There was a problem hiding this comment.
Is this necessary?
I'm not sure if anything depends on this in PoS.
There's been a recent change that allows "no tx" blocks to be built
Contributor
Author
There was a problem hiding this comment.
I think this is a good thing to have, otherwise to commit bundles you must have txs around and that makes some type of testing more hard. Also its more correct because this code does not know about bundles and assumes that if there are no txs then there is no way to create a non-empty block.
I don't think that this matters in PoS.
- It may matter only if people use our builder as a primary node for CL + EL setup. If we use this node as a builder this code is never called.
- Even then I don't think this matters because this is only short-circuit, meaning that in the absence of bugs in the sealing code the same output should happen but after some steps. E.g. if its prohibited by consensus to a real empty block then it should error in another place.
Ruteri
approved these changes
Dec 22, 2022
avalonche
pushed a commit
that referenced
this pull request
Dec 23, 2022
* Always recommit when creating blocks * Allow algo worker for local block creation
avalonche
pushed a commit
that referenced
this pull request
Feb 7, 2023
avalonche
pushed a commit
that referenced
this pull request
Feb 7, 2023
* Always recommit when creating blocks * Allow algo worker for local block creation
avalonche
pushed a commit
that referenced
this pull request
Mar 9, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 9, 2023
* Always recommit when creating blocks * Allow algo worker for local block creation
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Always recommit when creating blocks * Allow algo worker for local block creation
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
* Always recommit when creating blocks * Allow algo worker for local block creation
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
* Always recommit when creating blocks * Allow algo worker for local block creation
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
* Always recommit when creating blocks * Allow algo worker for local block creation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This change makes working with builder on local devnet more pleasant.