This repository was archived by the owner on Oct 25, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Approach looks great. Would you be able to share an example output? |
Contributor
Author
from http://127.0.0.1:6060/debug/metrics endpoint |
Ruteri
reviewed
Dec 21, 2022
| for _, enabler := range builderEnablerFlags { | ||
| if !EnabledBuilder && flag == enabler { | ||
| log.Info("Enabling builder metrics collection") | ||
| EnabledBuilder = true |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably have break
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to have, but it is the same convention as the other loops
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
Ruteri
reviewed
Dec 21, 2022
Ruteri
approved these changes
Dec 21, 2022
avalonche
pushed a commit
that referenced
this pull request
Feb 7, 2023
avalonche
pushed a commit
that referenced
this pull request
Feb 7, 2023
* high prio and low prio bundle fetcher
avalonche
added a commit
that referenced
this pull request
Feb 7, 2023
* Add metrics for builder * add metrics for individual simulations * Add builder metrics to README (#34)
avalonche
pushed a commit
that referenced
this pull request
Mar 9, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 9, 2023
* high prio and low prio bundle fetcher
avalonche
added a commit
that referenced
this pull request
Mar 9, 2023
* Add metrics for builder * add metrics for individual simulations * Add builder metrics to README (#34)
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
* high prio and low prio bundle fetcher
avalonche
added a commit
that referenced
this pull request
Mar 15, 2023
* Add metrics for builder * add metrics for individual simulations * Add builder metrics to README (#34)
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
* high prio and low prio bundle fetcher
avalonche
added a commit
that referenced
this pull request
Mar 17, 2023
* Add metrics for builder * add metrics for individual simulations * Add builder metrics to README (#34)
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
* high prio and low prio bundle fetcher
avalonche
added a commit
that referenced
this pull request
Mar 22, 2023
* Add metrics for builder * add metrics for individual simulations * Add builder metrics to README (#34)
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
* high prio and low prio bundle fetcher
avalonche
added a commit
that referenced
this pull request
Jul 6, 2023
* Add metrics for builder * add metrics for individual simulations * Add builder metrics to README (#34)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Add builder metrics for benchmarking performance. To accurately compare between merging algos, we need to some refactoring to provide general interfaces the merging algorithm.
Currently the metrics only records the performance for the greedy algorithm.
TODO:
📚 References
CONTRIBUTING.md