Skip to content

Conversation

@DavideIadeluca
Copy link
Contributor

Fixes #0000
#4118 (review)

Changes proposed in this pull request:
The change done in #4117 to increase the email field length is incomplete, as the email field in the email_tokens table needs to be adjusted as well (see #4118 (review))

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca changed the title fix: increase email field length in email_tokens as well fix: increase email field length in email_tokens Nov 22, 2024
@DavideIadeluca DavideIadeluca changed the title fix: increase email field length in email_tokens [1.x] fix: increase email field length in email_tokens Nov 22, 2024
@DavideIadeluca DavideIadeluca marked this pull request as ready for review November 22, 2024 10:07
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner November 22, 2024 10:07
@imorland imorland added this to the 1.8.10 milestone Nov 28, 2024
@imorland imorland merged commit be27dab into flarum:1.x Nov 28, 2024
322 checks passed
@imorland imorland deleted the di/fix-email-length-in-email-tokens branch November 28, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants