Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

set keepProcessEnv to false and re-enable react module-resolution test #107

Merged
dario-piotrowicz merged 3 commits into from
Dec 16, 2024
Merged

set keepProcessEnv to false and re-enable react module-resolution test #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dac262c
set `keepProcessEnv` to `false` and re-enable `react` module-resoluti…
dario-piotrowicz Dec 10, 2024
a00582b
remove `keepProcessEnv` altogether
dario-piotrowicz Dec 16, 2024
6e7c241
Revert "remove `keepProcessEnv` altogether"
dario-piotrowicz Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite-plugin-cloudflare/src/cloudflare-environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export function createCloudflareEnvironmentOptions(
],
},
},
keepProcessEnv: true,
keepProcessEnv: false,
};
}

Expand Down
4 changes: 1 addition & 3 deletions playground/module-resolution/__tests__/module-resolution.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,7 @@ describe('module resolution', async () => {
* special meaning to us.
*/
describe('third party packages resolutions', () => {
// TODO: we skip this test on build because a `ReferenceError: process is not defined` is thrown
// (https://github.com/flarelabs-net/vite-plugin-cloudflare/issues/82)
test.skipIf(isBuild)('react', async () => {
test('react', async () => {
const result = await getJsonResponse('/third-party/react');
expect(result).toEqual({
'(react) reactVersionsMatch': true,
Expand Down