Skip to content

Conversation

@jstucke
Copy link
Collaborator

@jstucke jstucke commented Apr 14, 2025

  • Adds a base class for unpacking plugins
    • is backwards compatible with old plugins (in fact only one plugin was converted to the new class as PoC)
    • makes boilerplate code at the end of plugins unnecessary
  • fixed a bug in the Xiaomi HDR and generic_carver plugins
    • the deactivated logging in the carver broke the logging output of the HDR unpacker
    • added log capturing to the generic carver instead (the same way it is implemented in the HDR unpacker)
  • analogous to Remove pluginbase FACT_core#985

@jstucke jstucke self-assigned this Apr 14, 2025
@jstucke jstucke force-pushed the plugin-base-class-poc branch from 64703c6 to 1dcbc6e Compare April 14, 2025 12:32
@jstucke jstucke changed the title Plugin base class poc unpacker plugin base class poc Apr 14, 2025
@jstucke jstucke force-pushed the plugin-base-class-poc branch from 1dcbc6e to d1eb4e9 Compare May 15, 2025 07:12
@jstucke jstucke force-pushed the plugin-base-class-poc branch from d1eb4e9 to 1dbcb9e Compare May 22, 2025 13:48
@jstucke jstucke marked this pull request as ready for review May 22, 2025 13:49
@jstucke jstucke force-pushed the plugin-base-class-poc branch from 1dbcb9e to ede97d5 Compare May 22, 2025 14:22
@jstucke jstucke force-pushed the plugin-base-class-poc branch from ede97d5 to 5b24f79 Compare June 4, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants