This repository was archived by the owner on Nov 8, 2023. It is now read-only.
Change unwrap to expect in index overloads#14
Merged
fitzgen merged 1 commit intofitzgen:masterfrom Jan 22, 2019
MggMuggins:master
Merged
Change unwrap to expect in index overloads#14fitzgen merged 1 commit intofitzgen:masterfrom MggMuggins:master
fitzgen merged 1 commit intofitzgen:masterfrom
MggMuggins:master
Conversation
Just bugged me that those just panic with very little indication of what goes on. Feels like it should be a little more helpful than that (since it can be). I'm really not picky on what the error message says, I'm happy to change it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just bugged me that those just panic with very little indication of what goes on. Feels like it should be a little more helpful than that (since it can be). I'm really not picky on what the error message says, I'm happy to change it.