Fix build issue with arm none eabi gcc v9.2.1 #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firmata/Firmata.h:131:17: error: friend declaration of 'void encodeByteStream(size_t, uint8_t*, size_t) const' specifies default arguments and isn't a definition [-fpermissive]
131 | friend void FirmataMarshaller::encodeByteStream (size_t bytec, uint8_t * bytev, size_t max_bytes = 0) const;
| ^~~~~~~~~~~~~~~~~
Ref:
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2000/n1263.html
Fixes #437
Signed-off-by: Frederic Pillon <[email protected]>
Contributor
|
@soundanalogous Do we know if the default value will still propogate from the declaration in https://github.com/firmata/arduino/blob/master/FirmataMarshaller.h#L67 I think your fix is the right way to handle this, but I want to be sure we aren't breaking the API. |
Member
Member
|
Tested with a bunch of examples from Breakout.js, didn't encounter any issues. |
Contributor
Author
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firmata/Firmata.h:131:17: error: friend declaration of 'void encodeByteStream(size_t, uint8_t*, size_t) const' specifies default arguments and isn't a definition [-fpermissive]
131 | friend void FirmataMarshaller::encodeByteStream (size_t bytec, uint8_t * bytev, size_t max_bytes = 0) const;
| ^~~~~~~~~~~~~~~~~
Ref:
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2000/n1263.html
Fixes #437