Skip to content

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Oct 28, 2025

Follow-up work

  • Migrate away from Ruby Xcodeproj (make an issue pot.)

@gemini-code-assist
Copy link

Summary of Changes

Hello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactoring of the 'InstallationsExample' project's naming conventions. The core objective is to eliminate the 'Swift' suffix from the application's main target, its test target, and all related files and configurations within the Xcode project. This change standardizes the project's naming, making it cleaner and more consistent across its various components.

Highlights

  • Project Target Renaming: The main application target has been renamed from 'InstallationsExampleSwift' to 'InstallationsExample', and its associated test target from 'InstallationsExampleSwiftTests' to 'InstallationsExampleTests'.
  • Xcode Project File Updates: The project.pbxproj file has been extensively updated to reflect the new target names across various configurations, including build file references, group names, native target definitions, product references, and build settings such as INFOPLIST_FILE, PRODUCT_BUNDLE_IDENTIFIER, and TEST_HOST.
  • File and Directory Renaming: All relevant application source files (e.g., AppDelegate.swift, ViewController.swift, Info.plist, Main.storyboard) and test files have been renamed, and their containing directories adjusted, to remove the 'Swift' suffix.
  • New Xcode Scheme: A new Xcode scheme file, InstallationsExample.xcscheme, has been added to align with the updated project and target names, ensuring proper build and test configurations.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/installations.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the Swift suffix from file names, paths, and project settings for the Installations example, aligning it with the naming conventions. The changes are consistent across the Xcode project file, scheme, and storyboard. I've found one minor inconsistency in a test file that was missed during the renaming, which I've commented on. Otherwise, the changes look good.

@ncooke3 ncooke3 merged commit 4d6b925 into nc/quickstarts Oct 28, 2025
3 of 4 checks passed
@ncooke3 ncooke3 deleted the nc/scheme-rename branch October 28, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant