-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(infra): Update scripts/test.sh to dynamically get scheme #1758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the scripts/test.sh script to automatically identify the correct Xcode scheme for testing Swift Package Manager projects. This change improves the script's reliability by removing hardcoded scheme names and adding robust error handling for scheme resolution.
Highlights
- Dynamic Scheme Detection: The scripts/test.sh file has been updated to dynamically determine the Xcode scheme for Swift Package Manager (SPM) projects.
- Improved Robustness: The script now attempts to find the correct scheme by checking for both base and OS-suffixed names, enhancing its adaptability.
- Error Handling: Added error handling to gracefully exit and inform the user if a suitable scheme cannot be found.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the test.sh script by dynamically determining the Xcode scheme instead of using a hardcoded value. This is a great enhancement for robustness. However, the implementation for extracting the list of schemes is fragile and could potentially pick up other items like build targets. I've provided a suggestion to make the scheme parsing more reliable.
| SCHEME="${SAMPLE}Example (${OS})" | ||
| # Get the list of schemes | ||
| schemes=$(xcodebuild -list -project "${DIR}/${SAMPLE}Example.xcodeproj" | | ||
| grep -E '^\s+' | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current grep command is not specific enough and can incorrectly match targets or build configurations as schemes, because it only checks for indentation. This can lead to build failures if a target name happens to match a scheme name pattern. To make this more robust, you should first isolate the 'Schemes:' section of the xcodebuild -list output before extracting the scheme names.
| grep -E '^\s+' | | |
| sed -n '/Schemes:/,/^$/p' | sed '1d;$d' | |
No description provided.