-
Notifications
You must be signed in to change notification settings - Fork 4.1k
chore: update lower bound dart dependency to 2.0.0 #2541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@2ZeroSix awesome - thanks for sorting :) beat me to it! Will get this reviewed tomorrow |
|
Hi @2ZeroSix, Looking at flutter/flutter#56930 this should probably be updated to make Dart 2.1.0 the minimum version, yeah? thanks! |
|
@domesticmouse I don’t know why @cyanglaz decided to upgrade version to 2.1.0. The fix is to use stable version higher than dev versions used in pubspec currently. Min stable dart version after 2.0.0-dev.* is 2.0.0 (I checked versioning docs and repo history to be sure) and I don’t see any reason to use 2.1.0 |
|
I think 2.0.0 is also fine as the plugins are not using any new language features. |
|
FYI. I enabled the CI on the flutter/plugin repo to use master channel for the publishing check in flutter/plugins@e26634c |
|
recently #2589 with these changes for [firebase_admob] was merged. |
Salakar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - will get this merged and published shortly.
Description
update sdk dependency: 2.0.0-dev.* => 2.0.0
Related Issues
same issue: flutter/flutter#56930
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?