Skip to content

Conversation

@2ZeroSix
Copy link
Contributor

Description

update sdk dependency: 2.0.0-dev.* => 2.0.0

Related Issues

same issue: flutter/flutter#56930

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@2ZeroSix
Copy link
Contributor Author

@Salakar did the same for cloud_functions as part of this PR #2519

@Salakar Salakar self-assigned this May 12, 2020
@Salakar
Copy link
Member

Salakar commented May 12, 2020

@2ZeroSix awesome - thanks for sorting :) beat me to it! Will get this reviewed tomorrow

@domesticmouse
Copy link
Contributor

Hi @2ZeroSix,

Looking at flutter/flutter#56930 this should probably be updated to make Dart 2.1.0 the minimum version, yeah?

thanks!

@2ZeroSix
Copy link
Contributor Author

@domesticmouse I don’t know why @cyanglaz decided to upgrade version to 2.1.0.

The fix is to use stable version higher than dev versions used in pubspec currently.

Min stable dart version after 2.0.0-dev.* is 2.0.0 (I checked versioning docs and repo history to be sure) and I don’t see any reason to use 2.1.0

@domesticmouse
Copy link
Contributor

@2ZeroSix SGTM.

PTAL @kroikie, this PR will help with CI issues.

@cyanglaz
Copy link

I think 2.0.0 is also fine as the plugins are not using any new language features.
Although 2.0.0 and 2.1.0 are both pretty old.

@cyanglaz
Copy link

FYI. I enabled the CI on the flutter/plugin repo to use master channel for the publishing check in flutter/plugins@e26634c
We might want to do the same for this repo if haven't already.

@domesticmouse
Copy link
Contributor

Thanks @cyanglaz, created #2578 with this change

@2ZeroSix
Copy link
Contributor Author

recently #2589 with these changes for [firebase_admob] was merged.
Should I do something to make this merged? Maybe split this into 14 pull requests (1 per package)?

Copy link
Member

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will get this merged and published shortly.

@Salakar Salakar changed the title [many] fix publishing check issue chore: update lower bound dart dependency to 2.0.0 May 25, 2020
@Salakar Salakar merged commit 15c7590 into firebase:master May 25, 2020
@firebase firebase locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants