Skip to content

[firebase_auth] Fix NoSuchMethodError exception in reauthenticateWithCredential #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
collinjackson merged 15 commits into from
Nov 18, 2019
Merged

[firebase_auth] Fix NoSuchMethodError exception in reauthenticateWithCredential #237

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d0bc32b
[firebase_auth] Fix NoSuchMethodError exception
fabryx92 Sep 29, 2019
f8a8441
[firebase_auth] Bump pubspec.yaml and update CHANGELOG for release 0.…
fabryx92 Sep 29, 2019
65b46ba
[firebase_auth] Fix the ios plugin for reauthenticateAndRetrieveDataW…
fabryx92 Oct 4, 2019
4e2828e
[firebase_auth] Fix FirebaseAuthPlugin.m formatting
fabryx92 Oct 4, 2019
bfac17a
[firebase_auth] Forget to return authResult in reauthenticateAndRetri…
fabryx92 Oct 4, 2019
62b5be4
[firebase_auth] Update the FirebaseAuthPlugin.m formatting
fabryx92 Oct 4, 2019
f167bd3
Add missing whitespace
collinjackson Oct 11, 2019
622aee4
Update packages/firebase_auth/CHANGELOG.md
fabryx92 Oct 14, 2019
3c0e256
Update CHANGELOG.md
fabryx92 Oct 14, 2019
cd26232
Merge branch 'master' into master
fabryx92 Nov 10, 2019
87bf4e5
add integration test
collinjackson Nov 18, 2019
7da108a
Merge remote-tracking branch 'origin/master' into reauthenticateWithC…
collinjackson Nov 18, 2019
6633220
Fix analyzer
collinjackson Nov 18, 2019
06cce09
reformat
collinjackson Nov 18, 2019
a9b33f4
fix changelog message
collinjackson Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/firebase_auth/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 0.14.0+7
* Fix NoSuchMethodError exception in `reauthenticateWithCredential`

## 0.14.0+6

* Update example app with correct const constructors.
Expand Down
4 changes: 2 additions & 2 deletions ...rebase_auth/android/src/main/java/io/flutter/plugins/firebaseauth/FirebaseAuthPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,8 +491,8 @@ private void handleReauthenticateWithCredential(
AuthCredential credential = getCredential((Map<String, Object>) call.arguments());

currentUser
.reauthenticate(credential)
.addOnCompleteListener(new TaskVoidCompleteListener(result));
.reauthenticateAndRetrieveData(credential)
.addOnCompleteListener(new SignInCompleteListener(result));
}

private void handleUnlinkFromProvider(MethodCall call, Result result, FirebaseAuth firebaseAuth) {
Expand Down
8 changes: 5 additions & 3 deletions packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,11 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
} else if ([@"reauthenticateWithCredential" isEqualToString:call.method]) {
[[self getAuth:call.arguments].currentUser
reauthenticateAndRetrieveDataWithCredential:[self getCredential:call.arguments]
completion:^(FIRAuthDataResult *r,
NSError *_Nullable error) {
[self sendResult:result forObject:nil error:error];
completion:^(FIRAuthDataResult *authResult,
NSError *error) {
[self sendResult:result
forAuthDataResult:authResult
error:error];
}];
} else if ([@"linkWithCredential" isEqualToString:call.method]) {
[[self getAuth:call.arguments].currentUser
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_auth/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Flutter plugin for Firebase Auth, enabling Android and iOS
like Google, Facebook and Twitter.
author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_auth
version: 0.14.0+6
version: 0.14.0+7

flutter:
plugin:
Expand Down