fix(firebase_database): Add modifiers to keepSynced ref in android #17978

deepak786 · 2026-01-27T15:54:25Z

Description

Add query modifiers to the database reference before applying the keepSynced.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

I read the Contributor Guide and followed the process outlined there for submitting PRs.
My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
All existing and new tests are passing.
I updated/added relevant documentation (doc comments with ///).
The analyzer (melos run analyze) does not report any problems on my PR.
I read and followed the Flutter Style Guide.
I signed the CLA.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change.
No, this is not a breaking change.

gemini-code-assist · 2026-01-27T15:54:29Z

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

SelaseKay · 2026-01-28T15:08:07Z

Hi @deepak786, thanks for the contribution. Kindly run melos format ci locally to resolve formatting issues. Other than that, LGTM.

deepak786 · 2026-01-28T15:22:44Z

@SelaseKay
melos format ci output

Building package executable... 
Built melos:melos.
$ melos format
  └> dart format .
     └> RUNNING (in 63 packages)

--------------------------------------------------------------------------------
_flutterfire_internals:
Formatted 5 files (0 changed) in 0.16 seconds.
_flutterfire_internals: SUCCESS
--------------------------------------------------------------------------------
cloud_firestore:
Formatted 49 files (0 changed) in 0.48 seconds.
cloud_firestore: SUCCESS
--------------------------------------------------------------------------------
cloud_firestore_example:
Formatted 22 files (0 changed) in 0.41 seconds.
cloud_firestore_example: SUCCESS
--------------------------------------------------------------------------------
cloud_firestore_platform_interface:
Formatted 62 files (0 changed) in 0.35 seconds.
cloud_firestore_platform_interface: SUCCESS
--------------------------------------------------------------------------------
cloud_firestore_web:
ERROR: Could not format because the source could not be parsed:

line 347, column 11 of lib/src/interop/firestore_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
347 │ extension type WriteBatchJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 362, column 11 of lib/src/interop/firestore_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
362 │ extension type CollectionReferenceJsImpl._(JSObject _) implements QueryJsImpl {
    │           ^^^^
    ╵
line 423, column 11 of lib/src/interop/firestore_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
423 │ extension type VectorValueJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 453, column 11 of lib/src/interop/firestore_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
453 │ extension type DocumentChangeJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 475, column 11 of lib/src/interop/firestore_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
475 │ extension type DocumentReferenceJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 491, column 11 of lib/src/interop/firestore_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
491 │ extension type LoadBundleTaskJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 502, column 11 of lib/src/interop/firestore_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
502 │ extension type LoadBundleTaskProgressJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 516, column 11 of lib/src/interop/firestore_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
516 │ extension type DocumentSnapshotJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 530, column 11 of lib/src/interop/firestore_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
530 │ extension type FieldValue._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 540, column 11 of lib/src/interop/firestore_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
540 │ extension type QueryJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
(11 more errors...)

Formatted 20 files (0 changed) in 0.28 seconds.
--------------------------------------------------------------------------------
cloud_functions:
Formatted 11 files (0 changed) in 0.19 seconds.
cloud_functions: SUCCESS
--------------------------------------------------------------------------------
cloud_functions_example:
Formatted 2 files (0 changed) in 0.13 seconds.
cloud_functions_example: SUCCESS
--------------------------------------------------------------------------------
cloud_functions_platform_interface:
Formatted 17 files (0 changed) in 0.23 seconds.
cloud_functions_platform_interface: SUCCESS
--------------------------------------------------------------------------------
cloud_functions_web:
ERROR: Could not format because the source could not be parsed:

line 42, column 11 of lib/interop/functions_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
42 │ extension type FunctionsJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 51, column 11 of lib/interop/functions_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
51 │ extension type HttpsCallableOptions._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 63, column 11 of lib/interop/functions_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
63 │ extension type HttpsCallableResultJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 67, column 11 of lib/interop/functions_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
67 │ extension type HttpsCallable._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 71, column 11 of lib/interop/functions_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
71 │ extension type HttpsCallableStreamResultJsImpl._(JSObject _)
   │           ^^^^
   ╵
line 77, column 11 of lib/interop/functions_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
77 │ extension type HttpsCallableStreamOptions._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 87, column 11 of lib/interop/functions_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
87 │ extension type JsAsyncIterator<T extends JSAny>._(JSObject _)
   │           ^^^^
   ╵
line 109, column 11 of lib/interop/functions_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
109 │ extension type HttpsStreamIterableResult._(JSObject _) implements JSObject {
    │           ^^^^
    ╵

Formatted 5 files (0 changed) in 0.17 seconds.
--------------------------------------------------------------------------------
firebase_ai:
Formatted 63 files (0 changed) in 0.48 seconds.
firebase_ai: SUCCESS
--------------------------------------------------------------------------------
firebase_ai_example:
Formatted 17 files (0 changed) in 0.25 seconds.
firebase_ai_example: SUCCESS
--------------------------------------------------------------------------------
firebase_analytics:
Formatted 8 files (0 changed) in 0.21 seconds.
firebase_analytics: SUCCESS
--------------------------------------------------------------------------------
firebase_analytics_example:
Formatted 3 files (0 changed) in 0.14 seconds.
firebase_analytics_example: SUCCESS
--------------------------------------------------------------------------------
firebase_analytics_platform_interface:
Formatted 11 files (0 changed) in 0.24 seconds.
firebase_analytics_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_analytics_web:
ERROR: Could not format because the source could not be parsed:

line 68, column 11 of lib/interop/analytics_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
68 │ extension type AnalyticsJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵

Formatted 6 files (0 changed) in 0.18 seconds.
--------------------------------------------------------------------------------
firebase_app_check:
Formatted 6 files (0 changed) in 0.16 seconds.
firebase_app_check: SUCCESS
--------------------------------------------------------------------------------
firebase_app_check_example:
Formatted 2 files (0 changed) in 0.12 seconds.
firebase_app_check_example: SUCCESS
--------------------------------------------------------------------------------
firebase_app_check_platform_interface:
Formatted 14 files (0 changed) in 0.19 seconds.
firebase_app_check_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_app_check_web:
ERROR: Could not format because the source could not be parsed:

line 67, column 11 of lib/src/interop/app_check_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
67 │ extension type AppCheckTokenResultJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 87, column 11 of lib/src/interop/app_check_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
87 │ extension type AppCheckJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵

Formatted 6 files (0 changed) in 0.18 seconds.
--------------------------------------------------------------------------------
firebase_app_installations:
ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

Formatted 5 files (0 changed) in 0.16 seconds.
firebase_app_installations: SUCCESS
--------------------------------------------------------------------------------
firebase_app_installations_example:
ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

Formatted 2 files (0 changed) in 0.12 seconds.
firebase_app_installations_example: SUCCESS
--------------------------------------------------------------------------------
firebase_app_installations_platform_interface:
ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

Formatted 4 files (0 changed) in 0.13 seconds.
firebase_app_installations_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_app_installations_web:
ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Could not format because the source could not be parsed:

line 34, column 11 of lib/src/interop/installations_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
34 │ extension type InstallationsJsImplExtension._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 38, column 11 of lib/src/interop/installations_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
38 │ extension type InstallationsJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵

Formatted 4 files (0 changed) in 0.14 seconds.
--------------------------------------------------------------------------------
firebase_auth:
Formatted 14 files (0 changed) in 0.28 seconds.
firebase_auth: SUCCESS
--------------------------------------------------------------------------------
firebase_auth_example:
Formatted 4 files (0 changed) in 0.17 seconds.
firebase_auth_example: SUCCESS
--------------------------------------------------------------------------------
firebase_auth_platform_interface:
Formatted 73 files (0 changed) in 0.44 seconds.
firebase_auth_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_auth_web:
ERROR: Could not format because the source could not be parsed:

line 294, column 11 of lib/src/interop/auth_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
294 │ extension type IdTokenResultImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 303, column 11 of lib/src/interop/auth_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
303 │ extension type UserInfoJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 313, column 11 of lib/src/interop/auth_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
313 │ extension type UserJsImpl._(JSObject _) implements UserInfoJsImpl {
    │           ^^^^
    ╵
line 331, column 11 of lib/src/interop/auth_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
331 │ extension type Persistence._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 568, column 11 of lib/src/interop/auth_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
568 │ extension type ConfirmationResultJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 576, column 11 of lib/src/interop/auth_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
576 │ extension type ActionCodeInfo._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 635, column 11 of lib/src/interop/auth_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
635 │ extension type AuthErrorCustomData._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 642, column 11 of lib/src/interop/auth_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
642 │ extension type ActionCodeData._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 749, column 11 of lib/src/interop/auth_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
749 │ extension type UserCredentialJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 800, column 11 of lib/src/interop/auth_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
800 │ extension type MultiFactorInfoJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
(4 more errors...)

Formatted 11 files (0 changed) in 0.27 seconds.
--------------------------------------------------------------------------------
firebase_core:
Formatted 7 files (0 changed) in 0.17 seconds.
firebase_core: SUCCESS
--------------------------------------------------------------------------------
firebase_core_example:
Formatted 2 files (0 changed) in 0.12 seconds.
firebase_core_example: SUCCESS
--------------------------------------------------------------------------------
firebase_core_platform_interface:
Formatted 17 files (0 changed) in 0.24 seconds.
firebase_core_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_core_web:
ERROR: Could not format because the source could not be parsed:

line 15, column 11 of lib/src/interop/app_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
15 │ extension type AppJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵

ERROR: Could not format because the source could not be parsed:

line 44, column 11 of lib/src/interop/core_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
44 │ extension type FirebaseErrorJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 55, column 11 of lib/src/interop/core_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
55 │ extension type FirebaseOptions._(JSObject _) implements JSObject {
   │           ^^^^
   ╵

Formatted 16 files (0 changed) in 0.20 seconds.
--------------------------------------------------------------------------------
firebase_crashlytics:
Formatted 7 files (0 changed) in 0.19 seconds.
firebase_crashlytics: SUCCESS
--------------------------------------------------------------------------------
firebase_crashlytics_example:
Formatted 2 files (0 changed) in 0.13 seconds.
firebase_crashlytics_example: SUCCESS
--------------------------------------------------------------------------------
firebase_crashlytics_platform_interface:
Formatted 8 files (0 changed) in 0.19 seconds.
firebase_crashlytics_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_data_connect:
ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

Formatted 65 files (0 changed) in 0.39 seconds.
firebase_data_connect: SUCCESS
--------------------------------------------------------------------------------
firebase_data_connect_example:
ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

Formatted 25 files (0 changed) in 0.21 seconds.
firebase_data_connect_example: SUCCESS
--------------------------------------------------------------------------------
firebase_database:
Formatted 17 files (0 changed) in 0.23 seconds.
firebase_database: SUCCESS
--------------------------------------------------------------------------------
firebase_database_example:
Formatted 2 files (0 changed) in 0.14 seconds.
firebase_database_example: SUCCESS
--------------------------------------------------------------------------------
firebase_database_platform_interface:
Formatted 29 files (0 changed) in 0.33 seconds.
firebase_database_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_database_web:
ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

ERROR: Could not format because the source could not be parsed:

line 7, column 11 of lib/src/interop/data_snapshot_interop.dart: This requires the 'inline-class' language feature to be enabled.
  ╷
7 │ extension type DataSnapshotJsImpl._(JSObject _) implements JSObject {
  │           ^^^^
  ╵

ERROR: Could not format because the source could not be parsed:

line 223, column 11 of lib/src/interop/database_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
223 │ extension type DatabaseJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 229, column 11 of lib/src/interop/database_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
229 │ extension type QueryConstraintJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 233, column 11 of lib/src/interop/database_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
233 │ extension type OnDisconnectJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 260, column 11 of lib/src/interop/database_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
260 │ extension type ThenableReferenceJsImpl._(JSObject _)
    │           ^^^^
    ╵
line 290, column 11 of lib/src/interop/database_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
290 │ extension type FirebaseError._(JSObject _) implements JSObject {
    │           ^^^^
    ╵

ERROR: Could not format because the source could not be parsed:

line 7, column 11 of lib/src/interop/query_interop.dart: This requires the 'inline-class' language feature to be enabled.
  ╷
7 │ extension type QueryJsImpl._(JSObject _) implements JSObject {
  │           ^^^^
  ╵

ERROR: Could not format because the source could not be parsed:

line 7, column 11 of lib/src/interop/reference_interop.dart: This requires the 'inline-class' language feature to be enabled.
  ╷
7 │ extension type TransactionResultJsImpl._(JSObject _) implements JSObject {
  │           ^^^^
  ╵
line 13, column 11 of lib/src/interop/reference_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
13 │ extension type ReferenceJsImpl._(JSObject _) implements JSObject, QueryJsImpl {
   │           ^^^^
   ╵

ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

Formatted 11 files (0 changed) in 0.20 seconds.
--------------------------------------------------------------------------------
firebase_in_app_messaging:
Formatted 4 files (0 changed) in 0.15 seconds.
firebase_in_app_messaging: SUCCESS
--------------------------------------------------------------------------------
firebase_in_app_messaging_example:
Formatted 2 files (0 changed) in 0.12 seconds.
firebase_in_app_messaging_example: SUCCESS
--------------------------------------------------------------------------------
firebase_in_app_messaging_platform_interface:
Formatted 6 files (0 changed) in 0.15 seconds.
firebase_in_app_messaging_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_messaging:
Formatted 10 files (0 changed) in 0.21 seconds.
firebase_messaging: SUCCESS
--------------------------------------------------------------------------------
firebase_messaging_example:
Formatted 6 files (0 changed) in 0.15 seconds.
firebase_messaging_example: SUCCESS
--------------------------------------------------------------------------------
firebase_messaging_platform_interface:
Formatted 15 files (0 changed) in 0.25 seconds.
firebase_messaging_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_messaging_web:
ERROR: Could not format because the source could not be parsed:

line 39, column 11 of lib/src/interop/messaging_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
39 │ extension type MessagingJsImpl._(JSObject _) implements JSObject {}
   │           ^^^^
   ╵
line 41, column 11 of lib/src/interop/messaging_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
41 │ extension type Observer._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 47, column 11 of lib/src/interop/messaging_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
47 │ extension type GetTokenOptions._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 57, column 11 of lib/src/interop/messaging_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
57 │ extension type NotificationPayloadJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 63, column 11 of lib/src/interop/messaging_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
63 │ extension type MessagePayloadJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 72, column 11 of lib/src/interop/messaging_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
72 │ extension type FcmOptionsJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵

Formatted 6 files (0 changed) in 0.18 seconds.
--------------------------------------------------------------------------------
firebase_ml_model_downloader:
ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

Formatted 6 files (0 changed) in 0.17 seconds.
firebase_ml_model_downloader: SUCCESS
--------------------------------------------------------------------------------
firebase_ml_model_downloader_example:
ERROR: Warning: Package resolution error when reading "analysis_options.yaml" file:
Failed to resolve package URI "package:flutter_lints/flutter.yaml" in include.

Formatted 2 files (0 changed) in 0.12 seconds.
firebase_ml_model_downloader_example: SUCCESS
--------------------------------------------------------------------------------
firebase_ml_model_downloader_platform_interface:
Formatted 10 files (0 changed) in 0.19 seconds.
firebase_ml_model_downloader_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_performance:
Formatted 9 files (0 changed) in 0.19 seconds.
firebase_performance: SUCCESS
--------------------------------------------------------------------------------
firebase_performance_example:
Formatted 3 files (0 changed) in 0.14 seconds.
firebase_performance_example: SUCCESS
--------------------------------------------------------------------------------
firebase_performance_platform_interface:
Formatted 18 files (0 changed) in 0.25 seconds.
firebase_performance_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_performance_web:
Formatted 6 files (0 changed) in 0.15 seconds.
firebase_performance_web: SUCCESS
--------------------------------------------------------------------------------
firebase_remote_config:
Formatted 7 files (0 changed) in 0.19 seconds.
firebase_remote_config: SUCCESS
--------------------------------------------------------------------------------
firebase_remote_config_example:
Formatted 3 files (0 changed) in 0.13 seconds.
firebase_remote_config_example: SUCCESS
--------------------------------------------------------------------------------
firebase_remote_config_platform_interface:
Formatted 10 files (0 changed) in 0.21 seconds.
firebase_remote_config_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_remote_config_web:
ERROR: Could not format because the source could not be parsed:

line 69, column 11 of lib/src/interop/firebase_remote_config_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
69 │ extension type RemoteConfigJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 79, column 11 of lib/src/interop/firebase_remote_config_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
79 │ extension type ValueJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 86, column 11 of lib/src/interop/firebase_remote_config_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
86 │ extension type SettingsJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 104, column 11 of lib/src/interop/firebase_remote_config_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
104 │ extension type ConfigUpdateObserverJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 110, column 11 of lib/src/interop/firebase_remote_config_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
110 │ extension type ConfigUpdateJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 122, column 11 of lib/src/interop/firebase_remote_config_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
122 │ extension type JSSet._(JSObject _) implements JSObject {
    │           ^^^^
    ╵

Formatted 6 files (0 changed) in 0.19 seconds.
--------------------------------------------------------------------------------
firebase_storage:
Formatted 19 files (0 changed) in 0.26 seconds.
firebase_storage: SUCCESS
--------------------------------------------------------------------------------
firebase_storage_example:
Formatted 5 files (0 changed) in 0.16 seconds.
firebase_storage_example: SUCCESS
--------------------------------------------------------------------------------
firebase_storage_platform_interface:
Formatted 29 files (0 changed) in 0.30 seconds.
firebase_storage_platform_interface: SUCCESS
--------------------------------------------------------------------------------
firebase_storage_web:
ERROR: Could not format because the source could not be parsed:

line 84, column 11 of lib/src/interop/storage_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
84 │ extension type StorageJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 93, column 11 of lib/src/interop/storage_interop.dart: This requires the 'inline-class' language feature to be enabled.
   ╷
93 │ extension type ReferenceJsImpl._(JSObject _) implements JSObject {
   │           ^^^^
   ╵
line 109, column 11 of lib/src/interop/storage_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
109 │ extension type FullMetadataJsImpl._(JSObject _)
    │           ^^^^
    ╵
line 146, column 11 of lib/src/interop/storage_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
146 │ extension type UploadMetadataJsImpl._(JSObject _)
    │           ^^^^
    ╵
line 161, column 11 of lib/src/interop/storage_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
161 │ extension type UploadTaskJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 173, column 11 of lib/src/interop/storage_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
173 │ extension type UploadTaskSnapshotJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 183, column 11 of lib/src/interop/storage_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
183 │ extension type SettableMetadataJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵
line 220, column 11 of lib/src/interop/storage_interop.dart: This requires the 'inline-class' language feature to be enabled.
    ╷
220 │ extension type ListResultJsImpl._(JSObject _) implements JSObject {
    │           ^^^^
    ╵

Formatted 14 files (0 changed) in 0.22 seconds.
--------------------------------------------------------------------------------
tests:
Formatted integration_test/firebase_auth/firebase_auth_instance_e2e_test.dart
Formatted integration_test/firebase_crashlytics/firebase_crashlytics_e2e_test.dart
Formatted integration_test/firebase_storage/task_e2e.dart
Formatted 36 files (3 changed) in 0.37 seconds.
tests: SUCCESS
--------------------------------------------------------------------------------

$ melos format
  └> dart format .
     └> FAILED (in 11 packages)
        └> cloud_firestore_web (with exit code 65)
        └> cloud_functions_web (with exit code 65)
        └> firebase_analytics_web (with exit code 65)
        └> firebase_app_check_web (with exit code 65)
        └> firebase_app_installations_web (with exit code 65)
        └> firebase_auth_web (with exit code 65)
        └> firebase_core_web (with exit code 65)
        └> firebase_database_web (with exit code 65)
        └> firebase_messaging_web (with exit code 65)
        └> firebase_remote_config_web (with exit code 65)
        └> firebase_storage_web (with exit code 65)

SelaseKay · 2026-01-28T15:32:03Z

Hi @deepak786, kindly revert to your original commit. I've created a PR to resolve the formatting. Once I merge, you can merge main into your branch and push your changes.

This reverts commit 9ab032d.

ahamed661177-8

J7788

SelaseKay · 2026-01-29T13:07:24Z

Hi @deepak786, kindly merge main into your branch and push your changes.

SelaseKay · 2026-01-29T13:17:10Z

Thanks, @deepak786. One last thing would be to add a test to cover this change.

deepak786 · 2026-01-29T14:05:17Z

@SelaseKay Which test?

deepak786 · 2026-01-29T14:30:46Z

There is no test for keepSync and I'm not sure how to verify this keepSync in test

ahamed661177-8

@ahamed661177-8

Add modifiers to the reference

a184158

Adjustments

edb44b1

Run melos format ci

9ab032d

Revert "Run melos format ci"

d90c110

This reverts commit 9ab032d.

ahamed661177-8 approved these changes Jan 29, 2026

View reviewed changes

Merge branch 'firebase:main' into fix_keep_synced_android

9c633f3

ahamed661177-8 approved these changes Jan 29, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(firebase_database): Add modifiers to keepSynced ref in android #17978

fix(firebase_database): Add modifiers to keepSynced ref in android #17978

deepak786 commented Jan 27, 2026

Uh oh!

gemini-code-assist bot commented Jan 27, 2026

Uh oh!

SelaseKay commented Jan 28, 2026

Uh oh!

deepak786 commented Jan 28, 2026

Uh oh!

SelaseKay commented Jan 28, 2026

Uh oh!

ahamed661177-8 left a comment

Uh oh!

SelaseKay commented Jan 29, 2026

Uh oh!

SelaseKay commented Jan 29, 2026

Uh oh!

deepak786 commented Jan 29, 2026 •

edited

Loading

Uh oh!

deepak786 commented Jan 29, 2026

Uh oh!

ahamed661177-8 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(firebase_database): Add modifiers to keepSynced ref in android #17978

Are you sure you want to change the base?

fix(firebase_database): Add modifiers to keepSynced ref in android #17978

Conversation

deepak786 commented Jan 27, 2026

Description

Related Issues

Checklist

Breaking Change

Uh oh!

gemini-code-assist bot commented Jan 27, 2026

Uh oh!

SelaseKay commented Jan 28, 2026

Uh oh!

deepak786 commented Jan 28, 2026

Uh oh!

SelaseKay commented Jan 28, 2026

Uh oh!

ahamed661177-8 left a comment

Choose a reason for hiding this comment

Uh oh!

SelaseKay commented Jan 29, 2026

Uh oh!

SelaseKay commented Jan 29, 2026

Uh oh!

deepak786 commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deepak786 commented Jan 29, 2026

Uh oh!

ahamed661177-8 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

deepak786 commented Jan 29, 2026 •

edited

Loading