Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/firebase_auth/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.14.0+9

* getIdToken use actual refresh value instead of checking if object exists

## 0.14.0+8

* Updated README instructions for contributing for consistency with other Flutterfire plugins.
Expand Down
5 changes: 5 additions & 0 deletions packages/firebase_auth/example/test/firebase_auth.dart
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ void main() {
expect(user.metadata.creationTime.isAfter(DateTime(2018, 1, 1)), isTrue);
expect(user.metadata.creationTime.isBefore(DateTime.now()), isTrue);
final IdTokenResult tokenResult = await user.getIdToken();
final String originalToken = tokenResult.token;
expect(tokenResult.token, isNotNull);
expect(tokenResult.expirationTime.isAfter(DateTime.now()), isTrue);
expect(tokenResult.authTime, isNotNull);
Expand All @@ -53,6 +54,10 @@ void main() {
expect(tokenResult.claims['provider_id'], 'anonymous');
expect(tokenResult.claims['firebase']['sign_in_provider'], 'anonymous');
expect(tokenResult.claims['user_id'], user.uid);
// Verify that token will be the same after another getIdToken call with refresh = false option
final IdTokenResult newTokenResultWithoutRefresh =
await user.getIdToken(refresh: false);
expect(originalToken, newTokenResultWithoutRefresh.token);
await auth.signOut();
final FirebaseUser user2 = (await auth.signInAnonymously()).user;
expect(user2.uid, isNot(equals(user.uid)));
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
}
} else if ([@"getIdToken" isEqualToString:call.method]) {
NSDictionary *args = call.arguments;
BOOL refresh = [args objectForKey:@"refresh"];
BOOL refresh = [[args objectForKey:@"refresh"] boolValue];
[[self getAuth:call.arguments].currentUser
getIDTokenResultForcingRefresh:refresh
completion:^(FIRAuthTokenResult *_Nullable tokenResult,
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_auth/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Flutter plugin for Firebase Auth, enabling Android and iOS
like Google, Facebook and Twitter.
author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_auth
version: 0.14.0+8
version: 0.14.0+9

flutter:
plugin:
Expand Down