Skip to content

Fixes strict compilation errors. #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mehmetf merged 4 commits into from
Nov 15, 2019
Merged

Fixes strict compilation errors. #1331

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8fe4da
Fixed Strict Compilation Errors
tommyzed Oct 30, 2019
09b6b84
Update CHANGELOG.md
tommyzed Oct 30, 2019
da83d4f
Update pubspec.yaml
tommyzed Oct 31, 2019
509144b
Merge branch 'master' into patch-1
tommyzed Nov 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/firebase_messaging/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 5.1.7
Copy link
Contributor

@mehmetf mehmetf Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also include a pubspec.yaml change.

Copy link
Contributor Author

@tommyzed tommyzed Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehmetf -- Can I add a file to an existing pull request or do I need to create a new one?

Copy link
Contributor Author

@tommyzed tommyzed Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I guess I can! thx :)


* Fix strict compilation errors.

## 5.1.6

* Fix warnings when compiling on Android.
Expand Down
4 changes: 2 additions & 2 deletions packages/firebase_messaging/ios/Classes/FirebaseMessagingPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ @interface FLTFirebaseMessagingPlugin () <FIRMessagingDelegate>

static FlutterError *getFlutterError(NSError *error) {
if (error == nil) return nil;
return [FlutterError errorWithCode:[NSString stringWithFormat:@"Error %ld", error.code]
return [FlutterError errorWithCode:[NSString stringWithFormat:@"Error %ld", (long)error.code]
message:error.domain
details:error.localizedDescription];
}
Expand Down Expand Up @@ -175,7 +175,7 @@ - (void)applicationDidBecomeActive:(UIApplication *)application {
application.applicationIconBadgeNumber = 0;
}

- (bool)application:(UIApplication *)application
- (BOOL)application:(UIApplication *)application
didReceiveRemoteNotification:(NSDictionary *)userInfo
fetchCompletionHandler:(void (^)(UIBackgroundFetchResult result))completionHandler {
[self didReceiveRemoteNotification:userInfo];
Expand Down