Adding Numeric Add #1365
Closed
Adding Numeric Add #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
Feiyang1,
bojeil-google,
depoll,
gsoltis,
hiranya911,
mikelehen,
rsgowman,
var-const,
wilhuff and
zxu123
as code owners
schmidt-sebastian
force-pushed
the
mrschmidt-increment
branch
3 times, most recently
from
ba3a2ae to
c831ba3
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-increment
branch
from
c831ba3 to
7356b55
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of firebase/firebase-android-sdk#105
Unlike Android, this PR doesn't treat INT64 overflows, as JavaScript's precision is limited to 53 bit. We likely can't properly expose the full backend semantics our customers, since we eventually surface the results as a
number.This limitation is currently - along with the rest of the API - going through API review.