Skip to content

Avoid eagerly evaluating unstrippedNativeLibsOverride during the configuration phase#8174

Open
OOS93 wants to merge 2 commits into
mainfrom
OOS93/gradle_unstripped_native_libs
Open

Avoid eagerly evaluating unstrippedNativeLibsOverride during the configuration phase#8174
OOS93 wants to merge 2 commits into
mainfrom
OOS93/gradle_unstripped_native_libs

Conversation

@OOS93
Copy link
Copy Markdown
Collaborator

@OOS93 OOS93 commented May 15, 2026

Current PR does a clean up for debugging methods which caused unstrippedNativeLibsDirs providers to be executed with no reason more than logging its value.

Also, current work modifies the logic performed at configuration phase, adding the use of a Provider as lazy initialization for unstrippedNativeLibsDirs.

At execution phase, it adds a check to ensure unstrippedNativeLibsDirs was set correctly (either using the recommended approach or added it manually with its corresponding "dependsOn" definition).

@OOS93 OOS93 requested a review from mrober May 15, 2026 15:57
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions
Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant