Skip to content

fix(firestore): Fix PreferRest caching issue #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2023
Merged

fix(firestore): Fix PreferRest caching issue #2040

merged 1 commit into from
Jan 13, 2023

Conversation

@lahirumaramba
Copy link
Member

@lahirumaramba lahirumaramba commented Jan 13, 2023 •
edited
Loading

  • Fixed a caching issue when a non-empty FirestoreSettings object is passed to initializeFirestore(...)
  • Improved test coverage for initializeFirestore()

Before:

initializeFirestore(app)
getFirestore(app) // works!

---

initializeFirestore(app, {})
getFirestore(app) // works!

---

initializeFirestore(app, { preferRest: true })
getFirestore(app) // throws `firestore/failed-precondition` error!

Related to: #1901

MarkDuckworth
MarkDuckworth approved these changes Jan 13, 2023
View reviewed changes
Copy link

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lahirumaramba lahirumaramba merged commit 6061ff6 into master Jan 13, 2023
@lahirumaramba lahirumaramba deleted the lm-fix-fs branch January 13, 2023 23:25
This was referenced Jan 17, 2023
Merged
Merged
@X-oss-byte X-oss-byte mentioned this pull request Jun 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

+2 more reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MarkDuckworth MarkDuckworth

Labels

release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lahirumaramba @MarkDuckworth @alexander-fenster @hsubox76