-
Notifications
You must be signed in to change notification settings - Fork 424
fix(firestore-bigquery-export): fixed "Converting circular structure to JSON" error (issue #236). #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| const data = traverse(eventData).map((property) => { | ||
|
|
||
| if (property instanceof firebase.firestore.DocumentReference) { | ||
| return property.path; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 Great job on finding the issue quickly @russellwheatley 🙏
Codecov Report
@@ Coverage Diff @@
## next #238 +/- ##
=======================================
Coverage 40.48% 40.48%
=======================================
Files 20 20
Lines 625 625
Branches 81 81
=======================================
Hits 253 253
Misses 370 370
Partials 2 2 |
|
@IanWyszynski is going to document how to build & deploy without the need to publish the npm package. I believe the rough steps are:
change the
and then deploy |
|
@russellwheatley Package has been published, you can test now. |
95c7c54 to
d6bf454
Compare
Fixes #236
Testing
Inserting data into Firestore database:
Result in BigQuery table: