Skip to content

Conversation

@russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Mar 24, 2020

Fixes #236

Testing

Inserting data into Firestore database:

Screenshot 2020-04-09 at 11 28 11

Result in BigQuery table:

Screenshot 2020-04-09 at 11 29 31

@googlebot googlebot added the cla: yes Author has signed the CLA label Mar 24, 2020
@russellwheatley russellwheatley self-assigned this Mar 24, 2020
@russellwheatley russellwheatley requested review from Ehesp and Salakar and removed request for Ehesp and Salakar March 24, 2020 11:26
const data = traverse(eventData).map((property) => {

if (property instanceof firebase.firestore.DocumentReference) {
return property.path;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Great job on finding the issue quickly @russellwheatley 🙏

@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #238 into next will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #238   +/-   ##
=======================================
  Coverage   40.48%   40.48%           
=======================================
  Files          20       20           
  Lines         625      625           
  Branches       81       81           
=======================================
  Hits          253      253           
  Misses        370      370           
  Partials        2        2           

@karayu karayu requested a review from jhuleatt March 31, 2020 22:10
@jhuleatt
Copy link
Collaborator

jhuleatt commented Apr 6, 2020

@IanWyszynski is going to document how to build & deploy without the need to publish the npm package. I believe the rough steps are:

  1. in firestore-bigquery-export/firestore-bigquery-change-tracker:

npm run build

  1. in firestore-bigquery-export/package.json:

change the "@firebaseextensions/firestore-bigquery-change-tracker" dependency to:

"@firebaseextensions/firestore-bigquery-change-tracker": "file:./firestore-bigquery-change-tracker",

  1. in firestore-bigquery-export/package.json:

npm run build

and then deploy

@laurenzlong
Copy link
Contributor

@russellwheatley Package has been published, you can test now.

@russellwheatley russellwheatley force-pushed the @invertase/bigquery-circular-ref branch from 95c7c54 to d6bf454 Compare April 8, 2020 09:48
@russellwheatley russellwheatley marked this pull request as ready for review April 8, 2020 17:55
@russellwheatley russellwheatley requested a review from a team as a code owner April 8, 2020 17:55
@russellwheatley russellwheatley requested review from Ehesp and Salakar April 9, 2020 07:15
@russellwheatley russellwheatley requested a review from Salakar April 9, 2020 12:24
@laurenzlong laurenzlong changed the title fix(firestore-big-query): print Reference path fix(firestore-bigquery-export): fix "Converting circular structure to JSON" (issue #236.) (#238) Apr 10, 2020
@laurenzlong laurenzlong changed the title fix(firestore-bigquery-export): fix "Converting circular structure to JSON" (issue #236.) (#238) fix(firestore-bigquery-export): fix "Converting circular structure to JSON" (issue #236). (#238) Apr 10, 2020
@laurenzlong laurenzlong changed the title fix(firestore-bigquery-export): fix "Converting circular structure to JSON" (issue #236). (#238) fix(firestore-bigquery-export): fix "Converting circular structure to JSON" (issue #236). Apr 10, 2020
@laurenzlong laurenzlong changed the title fix(firestore-bigquery-export): fix "Converting circular structure to JSON" (issue #236). fix(firestore-bigquery-export): prevent "Converting circular structure to JSON" error (issue #236). Apr 10, 2020
@laurenzlong laurenzlong changed the title fix(firestore-bigquery-export): prevent "Converting circular structure to JSON" error (issue #236). fix(firestore-bigquery-export): fixed "Converting circular structure to JSON" error (issue #236). Apr 10, 2020
@laurenzlong laurenzlong merged commit b6f108f into next Apr 10, 2020
@laurenzlong laurenzlong deleted the @invertase/bigquery-circular-ref branch April 10, 2020 22:33
@russellwheatley russellwheatley restored the @invertase/bigquery-circular-ref branch April 20, 2020 08:00
@russellwheatley russellwheatley deleted the @invertase/bigquery-circular-ref branch April 20, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Author has signed the CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when mirroring data to BigQuery TypeError: Converting circular structure to JSON

8 participants