Skip to content

Conversation

@joaqcid
Copy link
Contributor

@joaqcid joaqcid commented Feb 7, 2020

if you need to run gen-schema-views multiple times, you get an error "function already exists", adding "IF NOT EXISTS" to safely run script multiple times

@googlebot googlebot added the cla: yes Author has signed the CLA label Feb 7, 2020
@laurenzlong laurenzlong added the in-review Awaiting review by FE team. label Feb 19, 2020
@karayu karayu requested review from Ehesp and jmwski February 24, 2020 22:46
Copy link
Contributor

@jmwski jmwski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also require a patch version bump for the gen-schema-view package.

@karayu karayu added in-progress A fix or resolution is in progress and removed in-review Awaiting review by FE team. labels Mar 2, 2020
Copy link
Member

@Ehesp Ehesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Author has signed the CLA in-progress A fix or resolution is in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants