fix(storage-resize-images): ensure content type is always available #183
Conversation
Ehesp
added
do not merge
|
|
|
With what GitHub Issue is this PR associated? Could it please be added to the PR description? |
|
@rachelsaunders added it in, cross linked it from the issue rather than the PR. |
storage-resize-images/POSTINSTALL.md
Outdated
| 1. Go to your [Storage dashboard](https://console.firebase.google.com/project/${param:PROJECT_ID}/storage). | ||
|
|
||
| 1. Upload an image file to the bucket: `${param:IMG_BUCKET}` | ||
| 1. Upload an image file to the bucket: `${param:IMG_BUCKET}`. The file must have a valid [image MIME Type](https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types#Image_types), for example `image/png`. |
There was a problem hiding this comment.
Is this a really common case that a dev might not have the image MIME type specified? If not, then I wouldn't put this level of detail here in this uber quickstart section. Instead, I'd like to explore putting some of these known gotchas within the "Using this extension" section.
There was a problem hiding this comment.
Moved this "error" down in the POSTINSTALL file. Pls double-check that my change and additional text is correct? Thx!
There was a problem hiding this comment.
ping on this comment thread :-)
…be specified This "error" isn't a common error, so a warning about it doesn't really belong in the uber quickstart section. But, it seems that we're collecting a few "be aware of this or that" items, so it's better if we collect these into a specific section of the instructions doc.
7 participants
image/prefix.Fixes #175