Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@apphosting/adapter-nextjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@types/tmp": "*",
"mocha": "*",
"next": "~14.0.0",
"semver": "*",
"semver": "^7.7.3",
"tmp": "*",
"ts-mocha": "*",
"ts-node": "*",
Expand Down
2 changes: 2 additions & 0 deletions packages/@apphosting/adapter-nextjs/src/bin/build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
validateOutputDirectory,
getAdapterMetadata,
exists,
checkNextJSVersion,
} from "../utils.js";
import { join } from "path";
import { getBuildOptions, runBuild } from "@apphosting/common";
Expand All @@ -24,6 +25,7 @@ process.env.NEXT_PRIVATE_STANDALONE = "true";
// Opt-out sending telemetry to Vercel
process.env.NEXT_TELEMETRY_DISABLED = "1";

checkNextJSVersion(process.env.FRAMEWORK_VERSION);
const nextConfig = await loadConfig(root, opts.projectDirectory);

/**
Expand Down
46 changes: 46 additions & 0 deletions packages/@apphosting/adapter-nextjs/src/utils.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,52 @@ import path from "path";
import os from "os";
import { RoutesManifest, MiddlewareManifest } from "../src/interfaces.js";

describe("block vulnerable nextjs versions", () => {
it("check for vulnerable versions", async () => {
const { checkNextJSVersion } = await importUtils;

assert.throws(() => {
checkNextJSVersion("15.0.0");
});

assert.doesNotThrow(() => {
checkNextJSVersion(undefined);
});

assert.doesNotThrow(() => {
checkNextJSVersion("15.0.5");
});

assert.doesNotThrow(() => {
checkNextJSVersion("14.0.12");
});

assert.throws(() => {
checkNextJSVersion("14.3.0-canary.77");
});

assert.throws(() => {
checkNextJSVersion("14.3.0-canary.78");
});

assert.doesNotThrow(() => {
checkNextJSVersion("14.3.0-canary.76");
});

assert.throws(() => {
checkNextJSVersion("15.0.0-canary.2");
});

assert.throws(() => {
checkNextJSVersion("16.0.6");
});

assert.doesNotThrow(() => {
checkNextJSVersion("16.0.7");
});
});
});

describe("manifest utils", () => {
let tmpDir: string;
let distDir: string;
Expand Down
16 changes: 16 additions & 0 deletions packages/@apphosting/adapter-nextjs/src/utils.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import fsExtra from "fs-extra";
import semVer from "semver";
import { createRequire } from "node:module";
import { join, dirname, relative, normalize } from "path";
import { fileURLToPath } from "url";
Expand All @@ -17,6 +18,21 @@ import { OutputBundleConfig, updateOrCreateGitignore } from "@apphosting/common"
// fs-extra is CJS, readJson can't be imported using shorthand
export const { copy, exists, writeFile, readJson, readdir, readFileSync, existsSync, ensureDir } =
fsExtra;
export const { satisfies } = semVer;

const SAFE_NEXTJS_VERSIONS =
">=16.1.0 || ^16.0.7 || ^v15.5.7 || ^v15.4.8 || ^v15.3.6 || ^v15.2.6 || ^v15.1.9 || ^v15.0.5 || <14.3.0-canary.77";
Comment thread
annajowang marked this conversation as resolved.

export function checkNextJSVersion(version: string | undefined) {
if (!version) {
return;
}
if (!satisfies(version, SAFE_NEXTJS_VERSIONS)) {
throw new Error(
`CVE-2025-55182: Vulnerable Next version ${version} detected. Deployment blocked. Update your app's dependencies to a patched Next.js version and redeploy:https://nextjs.org/blog/CVE-2025-66478#fixed-versions`,
);
Comment on lines +31 to +33
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The CVE identifiers and URL in the error message appear to be placeholders and are likely incorrect. CVE-2025-55182 and CVE-2025-66478 reference a future year, and the CVEs are different in the message body and the URL. This could cause confusion for users who encounter this error.

To avoid providing misleading information, consider using a more generic error message until the correct CVE details and a valid advisory link are available.

    throw new Error(
      `Vulnerable Next.js version ${version} detected. Deployment blocked. Please update your app's dependencies to a patched Next.js version and redeploy. For more details, see the relevant security advisory.`,
    );

}
}

// Loads the user's next.config.js file.
export async function loadConfig(root: string, projectRoot: string): Promise<NextConfigComplete> {
Expand Down
96 changes: 53 additions & 43 deletions starters/nextjs/basic/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion starters/nextjs/basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"lint": "next lint"
},
"dependencies": {
"next": "15.0.0",
"next": "15.0.5",
"react": "^18",
"react-dom": "^18"
},
Expand Down