Skip to content

Add support for Node 24#429

Merged
leoortizz merged 4 commits intofirebase:mainfrom
service-paradis:support-node-24
Dec 9, 2025
Merged

Add support for Node 24#429
leoortizz merged 4 commits intofirebase:mainfrom
service-paradis:support-node-24

Conversation

@service-paradis
Copy link
Copy Markdown
Contributor

@service-paradis service-paradis commented Nov 24, 2025

Closes #425
Closes firebase/firebase-tools#9564

Firebase supports Node 24. We should be able to deploy frameworks using this version.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @service-paradis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces compatibility for Node.js 24, aligning the project with Firebase's support for this version. The primary goal is to enable developers to deploy frameworks utilizing Node.js 24, ensuring access to the latest runtime features and performance enhancements.

Highlights

  • Node.js 24 Support: The project now officially supports Node.js version 24, allowing frameworks to be deployed using this runtime.
  • Engine Compatibility Update: The engines.node field in both package.json and package-lock.json has been updated to include ^24.0.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Node.js version 24 to the firebase-frameworks package. The changes correctly update the engines field in package.json and the corresponding package-lock.json. The changes are straightforward and align with the goal of supporting the latest LTS versions of Node.js. The implementation is correct and I see no issues.

Copy link
Copy Markdown
Member

@leoortizz leoortizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @service-paradis! Left a question for @jamesdaniels

Comment thread packages/firebase-frameworks/package.json Outdated
Comment thread packages/firebase-frameworks/package.json Outdated
Comment thread package-lock.json Outdated
@leoortizz leoortizz requested a review from abhis3 as a code owner December 9, 2025 15:08
@leoortizz leoortizz merged commit d76fcf3 into firebase:main Dec 9, 2025
7 checks passed
@service-paradis service-paradis deleted the support-node-24 branch December 9, 2025 15:18
richwear1307 pushed a commit to richwear1307/horse-tipping-app that referenced this pull request Feb 27, 2026
* Add support for Node 24

* Update packages/firebase-frameworks/package.json

* Update package-lock.json

---------

Co-authored-by: Leonardo Ortiz <83593673+leoortizz@users.noreply.github.com>
AndySDis1 pushed a commit to AndySDis1/firebase-framework-tools that referenced this pull request Mar 7, 2026
* Add support for Node 24

* Update packages/firebase-frameworks/package.json

* Update package-lock.json

---------

Co-authored-by: Leonardo Ortiz <83593673+leoortizz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node v24 support Package firebase-frameworks is not compatible with Node@v24

4 participants