Make @apphosting/build package a commonjs type#406
Conversation
Summary of ChangesHello @annajowang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily transitions the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request converts the @apphosting/build package to a CommonJS module by removing the "type": "module" field from its package.json. While this is the main intended change, it introduces critical side effects. The project's test scripts and some source files still use ESM-specific features and import styles (like .js extensions in imports and import.meta.url), which will break in a CommonJS context. These inconsistencies need to be resolved for the package to build and test correctly.
This breaks e2e tests but functionality remains the same and this fixes builds on the CLI side.