Skip to content

Fix enum comparison in if predicate for SQL generation#4482

Merged
Yasirmod17 merged 1 commit intofinos:masterfrom
goldmansachs:review-enum-in-project-UDTF-fix
Mar 3, 2026
Merged

Fix enum comparison in if predicate for SQL generation#4482
Yasirmod17 merged 1 commit intofinos:masterfrom
goldmansachs:review-enum-in-project-UDTF-fix

Conversation

@ad-gs
Copy link
Contributor

@ad-gs ad-gs commented Feb 27, 2026

processDynaFunction: Disable pushDownEnumTransformations for the predicate of an if function (runs when returns non enum)
processIfForEnum: Same fix for the if path that returns enums. To avoid unquoted identifiers, resolve enum names in branches as string quoted literals

Added tests for scenarios with enum and non enum return types

@ad-gs ad-gs requested a review from a team as a code owner February 27, 2026 19:24
@github-actions
Copy link

Test Results

  1 070 files   -      18    1 070 suites   - 18   3h 12m 36s ⏱️ - 1h 20m 32s
13 638 tests  -      80  13 462 ✔️  -      80  176 💤 ±0  0 ±0 
32 139 runs   - 2 765  31 963 ✔️  - 2 765  176 💤 ±0  0 ±0 

Results for commit 52be9d7. ± Comparison against base commit 3c92e3c.

@Yasirmod17 Yasirmod17 merged commit 08ff20d into finos:master Mar 3, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants