Skip to content

Legend SQL - fix having on realised and cross join within set operation#4477

Merged
gs-jp1 merged 2 commits intofinos:masterfrom
goldmansachs:review-jp-havingfix
Feb 27, 2026
Merged

Legend SQL - fix having on realised and cross join within set operation#4477
gs-jp1 merged 2 commits intofinos:masterfrom
goldmansachs:review-jp-havingfix

Conversation

@gs-jp1
Copy link
Contributor

@gs-jp1 gs-jp1 commented Feb 27, 2026

What type of PR is this?

Bug Fix

What does this PR do / why is it needed ?

  1. handle the case where having clause is on an aggregation of a realised column
  2. handle cross joins within a set operation

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

@gs-jp1 gs-jp1 requested a review from a team as a code owner February 27, 2026 10:25
@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Test Results

  1 070 files  +    2    1 070 suites  +2   3h 14m 55s ⏱️ - 28m 3s
13 636 tests +    3  13 460 ✔️ +    3  176 💤 ±0  0 ±0 
32 137 runs  +430  31 961 ✔️ +430  176 💤 ±0  0 ±0 

Results for commit d572cc7. ± Comparison against base commit 631dc86.

♻️ This comment has been updated with latest results.

@gs-jp1 gs-jp1 merged commit 3c92e3c into finos:master Feb 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants