Skip to content

Update for changes to metadata ids #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevin-m-knight-gs merged 1 commit into from
Feb 26, 2026
Merged

Update for changes to metadata ids #4476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ...r/src/main/java/org/finos/legend/engine/language/pure/compiler/toPureGraph/PureModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,6 +939,10 @@ public Type getType_safe(String fullPath)

// Search for system types in the Pure graph
type = tryGetFromMetadataAccessor(fullPath, MetadataAccessor::getClass, MetadataAccessor::getEnumeration, MetadataAccessor::getPrimitiveType, MetadataAccessor::getMeasure, MetadataAccessor::getUnit);
if (type == null)
{
type = tryGetUnitByLegacyId(fullPath);
}
if (type != null)
{
this.immutables.add(fullPathWithPrefix);
Expand All @@ -952,6 +956,25 @@ public Type getType_safe(String fullPath)
return type;
}

private Unit tryGetUnitByLegacyId(String legacyId)
{
int unitDelimiterIndex = legacyId.lastIndexOf('~');
if (unitDelimiterIndex != -1)
{
String measurePath = legacyId.substring(0, unitDelimiterIndex);
Measure measure = tryGetFromMetadataAccessor(measurePath, MetadataAccessor::getMeasure);
if (measure != null)
{
String unitName = legacyId.substring(unitDelimiterIndex + 1);
Unit canonicalUnit = measure._canonicalUnit();
return ((canonicalUnit != null) && unitName.equals(canonicalUnit._name())) ?
canonicalUnit :
measure._nonCanonicalUnits().detect(ncu -> unitName.equals(ncu._name()));
}
}
return null;
}

public org.finos.legend.pure.m3.coreinstance.meta.pure.metamodel.type.Class<?> getClass(String fullPath)
{
return this.getClass(fullPath, SourceInformation.getUnknownSourceInformation());
Expand Down
13 changes: 1 addition & 12 deletions ...g/finos/legend/pure/runtime/java/extension/relation/compiled/pure/TestFunctionTester.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,10 @@

package org.finos.legend.pure.runtime.java.extension.relation.compiled.pure;

import org.finos.legend.pure.m3.exception.PureExecutionException;
import org.finos.legend.pure.m3.execution.FunctionExecution;
import org.finos.legend.pure.m3.tests.function.base.PureExpressionTest;
import org.finos.legend.pure.runtime.java.compiled.execution.FunctionExecutionCompiledBuilder;
import org.junit.After;
import org.junit.Assert;
import org.junit.BeforeClass;
import org.junit.Test;

Expand Down Expand Up @@ -59,16 +57,7 @@ public void sortOnTdsWithVariant()
" 5, \"[13,14,15]\"\n" +
" #->extend(~reversed:x | $x.payload->toMany(@Integer)->reverse()->toVariant()));\n" +
"}");
try
{
this.execute("test():Any[*]");
Assert.fail("Error thrown when executing test function");
}
catch (PureExecutionException e)
{
// metadata fails...
Assert.assertTrue(e.getMessage().contains(" of type meta::pure::metamodel::type::FunctionType does not exist"));
}
execute("test():Any[*]");
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@

<properties>
<!-- Legend -->
<legend.pure.version>5.76.1</legend.pure.version>
<legend.pure.version>5.78.0</legend.pure.version>
<legend.shared.version>0.33.0</legend.shared.version>
<legend.web-application.version>13.2.0</legend.web-application.version>
<legend.pylegend.version>0.14.0</legend.pylegend.version>
Expand Down
Loading