Test current balance behaviour in recursive sends

[anorth]

Actor A invokes a method on Actor B and supplies a nonzero value. Before Actor B’s execution is complete, it invokes a method on Actor A, but does NOT supply value. Within this context, CurrentBalance should factor in the amount initially sent to Actor B.

Finally, Actor B’s execution finishes successfully and Actor A continues execution where it left off. CurrentBalance should factor in the amount sent to Actor B.

Via @wadealexc

[raulk]

@anorth are these questions about which behaviour is correct (which would need to be discussed in the team)? Or are these test scenarios worded as questions?

[anorth]

I've removed the question marks - they reflect expected behaviour to be tested.

[raulk]

@willscott We'll need the chaos actor to test this.

Suggestion: add a RecursiveSend method that takes a recursion level (big.Int) as an arg, and returns a slice of []abi.TokenAmount where we'd accumulate all observed balances in each recursion level.

• ChaosActor#RecursiveSend(n)
  • records the observed balance in a local var.
  • if n-1 != 0, calls ChaosActor#RecursiveSend(n-1), else it returns the recorded balance immediately in a slice of len == 1.
  • prepend the recorded value to the returned array.

[anorth]

Sends from an actor to itself are a whole extra class additional to what I described originally, which should definitely be included. For a self-send with value, I would expect the observed balance to not change because it is subtracted and then added to the same actor.

To test the balance changes originally described, you'll need at least two instances of the chaos actor, one sending to the other.