feat: use upstream group, ff and pairing dependencies#1488
Merged
Conversation
DrPeterVanNostrand
force-pushed
the
halo
branch
from
c16831c to
1d7a0c0
Compare
DrPeterVanNostrand
requested review from
cryptonemo and
dignifiedquire
as code owners
Contributor
|
Nice, thanks @DrPeterVanNostrand! Will start reviewing next week. |
Contributor
Author
|
Note that this PR removes all ci jobs starting with the string |
DrPeterVanNostrand
left a comment
DrPeterVanNostrand
left a comment
Contributor
Author
There was a problem hiding this comment.
Cargo.toml's should be updated before merging.
| ff = "0.10.0" | ||
| blake2b_simd = "0.5" | ||
| bellperson = { version = "0.16", default-features = false } | ||
| bellperson = { git = "https://github.com/filecoin-project/bellperson", branch = "halo" } |
Contributor
Author
There was a problem hiding this comment.
This should be changed before merging.
| memmap = "0.7.0" | ||
| bellperson = { version = "0.16", default-features = false } | ||
| rand = "0.7" | ||
| bellperson = { git = "https://github.com/filecoin-project/bellperson", branch = "halo" } |
Contributor
Author
There was a problem hiding this comment.
This should be changed before merging.
|
|
||
| [dependencies] | ||
| bellperson = { version = "0.16", default-features = false } | ||
| bellperson = { git = "https://github.com/filecoin-project/bellperson", branch = "halo" } |
Contributor
Author
There was a problem hiding this comment.
This should be changed before merging.
| rand = "0.8.0" | ||
|
|
||
| neptune = { version = "^4.0", default-features = false, optional = true } | ||
| neptune = { git = "https://github.com/filecoin-project/neptune", branch = "halo", optional = true } |
Contributor
Author
There was a problem hiding this comment.
This should be changed before merging.
| ff = "0.10.0" | ||
| blake2b_simd = "0.5" | ||
| bellperson = { version = "0.16", default-features = false } | ||
| bellperson = { git = "https://github.com/filecoin-project/bellperson", branch = "halo" } |
Contributor
Author
There was a problem hiding this comment.
This should be changed before merging.
| anyhow = "1.0.23" | ||
| thiserror = "1.0.6" | ||
| neptune = { version = "^4.0", default-features = false } | ||
| neptune = { git = "https://github.com/filecoin-project/neptune", branch = "halo" } |
Contributor
Author
There was a problem hiding this comment.
This should be changed before merging.
| ff = { version = "0.3.1", package = "fff" } | ||
| bellperson = { version = "0.16", default-features = false } | ||
| ff = "0.10.0" | ||
| bellperson = { git = "https://github.com/filecoin-project/bellperson", branch = "halo" } |
Contributor
Author
There was a problem hiding this comment.
This should be changed before merging.
| generic-array = "0.14.4" | ||
| anyhow = "1.0.23" | ||
| neptune = { version = "^4.0", default-features = false } | ||
| neptune = { git = "https://github.com/filecoin-project/neptune", branch = "halo" } |
Contributor
Author
There was a problem hiding this comment.
This should be changed before merging.
| ff = { version = "0.3.1", package = "fff" } | ||
| bellperson = { version = "0.16", default-features = false } | ||
| ff = "0.10.0" | ||
| bellperson = { git = "https://github.com/filecoin-project/bellperson", branch = "halo" } |
Contributor
Author
There was a problem hiding this comment.
This should be changed before merging.
| generic-array = "0.14.4" | ||
| anyhow = "1.0.23" | ||
| neptune = { version = "^4.0", default-features = false } | ||
| neptune = { git = "https://github.com/filecoin-project/neptune", branch = "halo" } |
Contributor
Author
There was a problem hiding this comment.
This should be changed before merging.
DrPeterVanNostrand
force-pushed
the
halo
branch
from
1d7a0c0 to
098341b
Compare
10 tasks
cryptonemo
reviewed
Aug 23, 2021
cryptonemo
left a comment
cryptonemo
left a comment
Contributor
There was a problem hiding this comment.
Needs a rebase, but looks good!
6 tasks
dignifiedquire
force-pushed
the
halo
branch
2 times, most recently
from
890a777 to
e694f49
Compare
dignifiedquire
force-pushed
the
halo
branch
from
e694f49 to
871d8ae
Compare
dignifiedquire
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filecoin-hashersfr32storage-proofs-corestorage-proofs-porepstorage-proofs-postfilecoin-proofsNote that this PR removes the
pairingandblstfeatures and drops support forpaired's BLS12-381 implementation.