Audit: Update total challenge count and increase partitions.#1153
Merged
Conversation
porcuquine
force-pushed
the
fix/challenges-and-partitions
branch
from
2830ea9 to
aae82ce
Compare
dignifiedquire
previously approved these changes
Jun 5, 2020
nicola
previously approved these changes
Jun 5, 2020
Contributor
|
@porcuquine I'll approve once rebased |
porcuquine
force-pushed
the
fix/challenges-and-partitions
branch
from
aae82ce to
d1107d1
Compare
cryptonemo
approved these changes
Jun 5, 2020
cryptonemo
left a comment
cryptonemo
left a comment
Contributor
There was a problem hiding this comment.
Approved if CI approves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal audit found we should be using more total challenges in PoRep. This PR raises the minimum challenges to
180176 and the partitions to 10, for both 32GiB and 64GiB sectors. The partition count increases so circuit size will not.