chain/migrations refactor: optionally set max migration workers#9784
Merged
chain/migrations refactor: optionally set max migration workers#9784
Conversation
- configure via LOTUS_MIGRATION_MAX_WORKER_COUNT
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ZenGround0
approved these changes
Dec 2, 2022
magik6k
reviewed
Dec 2, 2022
Co-authored-by: Łukasz Magiera <[email protected]>
magik6k
approved these changes
Dec 5, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Allow the maximum number of workers for state migrations to be specified via an environment variable LOTUS_MIGRATION_MAX_WORKER_COUNT
Additional Info
Limits the number of actors being migrated simultaneously, thus reducing the overall memory footprint required by migrations. Motivated by experience in production where nodes with high CPU count exhaust all available memory due to a high number of workers loading actor states into memory to perform migration.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps