Skip to content

Removing CID Lists Part 2: Deprecating protocols#293

Merged
hannahhoward merged 3 commits intomasterfrom
feat/deprecate-protocols
Jan 14, 2022
Merged

Removing CID Lists Part 2: Deprecating protocols#293
hannahhoward merged 3 commits intomasterfrom
feat/deprecate-protocols

Conversation

@hannahhoward
Copy link
Collaborator

Goals

Remove a whole lot of unused code for releases that no running filecoin node will need to support

Implementation

  • remove cid sets
  • remove cid lists
  • remove message 1_0 and associated graphsync extensions

@hannahhoward hannahhoward force-pushed the feat/deprecate-protocols branch from c89b69b to 5fa0172 Compare January 14, 2022 06:25
@hannahhoward hannahhoward changed the base branch from master to feat/remove-cid-lists-sender January 14, 2022 06:28
@hannahhoward hannahhoward requested a review from dirkmc January 14, 2022 06:29
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@hannahhoward hannahhoward force-pushed the feat/remove-cid-lists-sender branch from 3f3a1a3 to d76e5dc Compare January 14, 2022 22:19
@hannahhoward hannahhoward force-pushed the feat/deprecate-protocols branch from 5fa0172 to 85b4764 Compare January 14, 2022 22:44
@hannahhoward hannahhoward changed the base branch from feat/remove-cid-lists-sender to master January 14, 2022 22:45
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.67%. Comparing base (7def500) to head (85b4764).
Report is 58 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
- Coverage   68.15%   67.67%   -0.49%     
==========================================
  Files          25       24       -1     
  Lines        3344     3186     -158     
==========================================
- Hits         2279     2156     -123     
+ Misses        695      683      -12     
+ Partials      370      347      -23     
Files with missing lines Coverage Δ
channels/channel_state.go 80.85% <100.00%> (+4.80%) ⬆️
channels/channels.go 72.72% <100.00%> (-0.34%) ⬇️
impl/impl.go 64.94% <100.00%> (-0.48%) ⬇️
message/message1_1/transfer_request.go 69.49% <100.00%> (-8.89%) ⬇️
message/message1_1/transfer_response.go 90.24% <100.00%> (-5.99%) ⬇️
network/libp2p_impl.go 66.47% <100.00%> (+1.52%) ⬆️
transport/graphsync/graphsync.go 76.41% <100.00%> (+0.50%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hannahhoward hannahhoward merged commit a12f639 into master Jan 14, 2022
zl03jsj added a commit to filecoin-project/venus that referenced this pull request Apr 20, 2022
go-data-transfer(filecoin-project/go-data-transfer#293),
it's dir is no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants