Skip to content

Conversation

@People-Sea
Copy link
Member

@People-Sea People-Sea commented Jan 29, 2026

Description

Fixes #19116

The livewireComponent parameter in databaseNotifications() was stored but never used - views hardcoded DatabaseNotifications::class instead of reading the configured component.

Visual changes

Before

image

After

image

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@github-project-automation github-project-automation bot moved this to Todo in Roadmap Jan 29, 2026
@People-Sea People-Sea marked this pull request as ready for review January 29, 2026 05:00
@danharrin danharrin added the bug Something isn't working label Jan 29, 2026
@danharrin danharrin added this to the v4 milestone Jan 29, 2026
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Roadmap Jan 29, 2026
@danharrin danharrin merged commit 6224fdd into filamentphp:4.x Jan 29, 2026
24 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Jan 29, 2026
@People-Sea People-Sea deleted the fix/issues/19116 branch January 29, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[v4] databaseNotifications() livewireComponent parameter is never used

2 participants